From 48c508860d367d984da6fa55e77e5f8b1a0b106f Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Tue, 27 Aug 2019 06:22:58 -0700 Subject: [PATCH] fix(typescript): add peerDependency on typescript Set it to 3.0 or greater. This lets us drop some e2e testing which was taking a long time on CI. Also add e2e testing for TS 3.6 which was just released. Note that typescript doesn't do semver so it's possible that something breaks before 4.0. If users report that, we'll have to re-publish with a narrowed range. --- e2e/BUILD.bazel | 4 +--- packages/typescript/src/package.json | 4 ++++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/e2e/BUILD.bazel b/e2e/BUILD.bazel index bdea270f6e..2e86cf47f5 100644 --- a/e2e/BUILD.bazel +++ b/e2e/BUILD.bazel @@ -134,15 +134,13 @@ e2e_integration_test( }, workspace_files = "@e2e_typescript//:all_files", ) for tsc_version in [ - "2.7.x", - "2.8.x", - "2.9.x", "3.0.x", "3.1.x", "3.2.x", "3.3.x", "3.4.x", "3.5.x", + "3.6.x", ]] e2e_integration_test( diff --git a/packages/typescript/src/package.json b/packages/typescript/src/package.json index cb8f7ffeff..406afd07d6 100644 --- a/packages/typescript/src/package.json +++ b/packages/typescript/src/package.json @@ -21,6 +21,10 @@ "ts_auto_deps": "./ts_auto_deps/ts_auto_deps.js", "tsc_wrapped": "./internal/tsc_wrapped/tsc_wrapped.js" }, + "//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us", + "peerDependencies": { + "typescript": ">=3.0.0 <4.0" + }, "dependencies": { "protobufjs": "6.8.8", "semver": "5.6.0",