Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: default to nobazel_patch_module_resolver #2324

Closed
wants to merge 19 commits into from

Commits on Dec 9, 2020

  1. refactor: default to nobazel_patch_module_resolver

    This turns off our monkey-patches for require() for nodejs_binary, nodejs_test, and macros like jasmine_node_test.
    Note it was previously disabled for npm_package_bin and generated index.bzl binaries in bazel-contrib#1440
    
    BREAKING CHANGE:
    we no longer patch the require() function, instead you should rely on the linker to make node modules resolvable at the standard location
    if this breaks you, try opting-in to the require patches with templated_args = ["--bazel_patch_module_resolver"]
    
    Fixes bazel-contrib#2125
    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    fa88f38 View commit details
    Browse the repository at this point in the history
  2. fix(terser): use runfiles helper rather than rely on monkey-patched r…

    …equire
    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b410184 View commit details
    Browse the repository at this point in the history
  3. chore: patch rules_sass PR 126

    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    8b781b8 View commit details
    Browse the repository at this point in the history
  4. fix(create): use runfiles helper rather than rely on monkey-patched r…

    …equire
    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e5263a4 View commit details
    Browse the repository at this point in the history
  5. chore: fix internal to declare needing patched module resolver, or us…

    …e runfiles
    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    fe784d9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7aa5324 View commit details
    Browse the repository at this point in the history
  7. fix(concatjs): use runfiles helper rather than rely on monkey-patched…

    … require
    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    88a49c4 View commit details
    Browse the repository at this point in the history
  8. chore: fix protractor

    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1c8d6e5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f70ae45 View commit details
    Browse the repository at this point in the history
  10. chore: add rules_sass patch for downstream projects

    Alex Eagle committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    6bf8ae7 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. chore: try to fix remaining CI failures for --nobazel_patch_module_re…

    …solver
    Alex Eagle committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    9a5a5c1 View commit details
    Browse the repository at this point in the history
  2. chore: tsc_wrapped worker mode needs require patches

    Alex Eagle committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5caf332 View commit details
    Browse the repository at this point in the history
  3. chore: try to fix CI: angular plugins

    Alex Eagle committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    185c253 View commit details
    Browse the repository at this point in the history
  4. chore: fix lit plugin

    Alex Eagle committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    22853dd View commit details
    Browse the repository at this point in the history
  5. chore: more fixes for no-runfiles case

    Alex Eagle committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    a8de6f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. chore: fix the last one?

    Alex Eagle committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    8b33a07 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0b08d5 View commit details
    Browse the repository at this point in the history
  3. fix(builtin): --nobazel_run_linker implies --bazel_patch_module_resolver

    If you turn off the linker, you're reverting to earlier rules_nodejs behavior where third-party node modules can
    only be resolved using the patched require() function that knows where to find them
    Alex Eagle committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    2844c97 View commit details
    Browse the repository at this point in the history
  4. chore: reduce the delta more

    Alex Eagle committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    532cc2a View commit details
    Browse the repository at this point in the history