-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: default to nobazel_patch_module_resolver #2324
Commits on Dec 9, 2020
-
refactor: default to nobazel_patch_module_resolver
This turns off our monkey-patches for require() for nodejs_binary, nodejs_test, and macros like jasmine_node_test. Note it was previously disabled for npm_package_bin and generated index.bzl binaries in bazel-contrib#1440 BREAKING CHANGE: we no longer patch the require() function, instead you should rely on the linker to make node modules resolvable at the standard location if this breaks you, try opting-in to the require patches with templated_args = ["--bazel_patch_module_resolver"] Fixes bazel-contrib#2125
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for fa88f38 - Browse repository at this point
Copy the full SHA fa88f38View commit details -
fix(terser): use runfiles helper rather than rely on monkey-patched r…
…equire
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for b410184 - Browse repository at this point
Copy the full SHA b410184View commit details -
chore: patch rules_sass PR 126
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 8b781b8 - Browse repository at this point
Copy the full SHA 8b781b8View commit details -
fix(create): use runfiles helper rather than rely on monkey-patched r…
…equire
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for e5263a4 - Browse repository at this point
Copy the full SHA e5263a4View commit details -
chore: fix internal to declare needing patched module resolver, or us…
…e runfiles
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for fe784d9 - Browse repository at this point
Copy the full SHA fe784d9View commit details -
fix(labs): use runfiles helper rather than rely on monkey-patched req…
…uire
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 7aa5324 - Browse repository at this point
Copy the full SHA 7aa5324View commit details -
fix(concatjs): use runfiles helper rather than rely on monkey-patched…
… require
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 88a49c4 - Browse repository at this point
Copy the full SHA 88a49c4View commit details -
Alex Eagle committed
Dec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 1c8d6e5 - Browse repository at this point
Copy the full SHA 1c8d6e5View commit details -
chore: next batch of bazel_patch_module_resolver fixes
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for f70ae45 - Browse repository at this point
Copy the full SHA f70ae45View commit details -
chore: add rules_sass patch for downstream projects
Alex Eagle committedDec 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 6bf8ae7 - Browse repository at this point
Copy the full SHA 6bf8ae7View commit details
Commits on Dec 10, 2020
-
chore: try to fix remaining CI failures for --nobazel_patch_module_re…
…solver
Alex Eagle committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 9a5a5c1 - Browse repository at this point
Copy the full SHA 9a5a5c1View commit details -
chore: tsc_wrapped worker mode needs require patches
Alex Eagle committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 5caf332 - Browse repository at this point
Copy the full SHA 5caf332View commit details -
chore: try to fix CI: angular plugins
Alex Eagle committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 185c253 - Browse repository at this point
Copy the full SHA 185c253View commit details -
Alex Eagle committed
Dec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 22853dd - Browse repository at this point
Copy the full SHA 22853ddView commit details -
chore: more fixes for no-runfiles case
Alex Eagle committedDec 10, 2020 Configuration menu - View commit details
-
Copy full SHA for a8de6f5 - Browse repository at this point
Copy the full SHA a8de6f5View commit details
Commits on Dec 11, 2020
-
Alex Eagle committed
Dec 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 8b33a07 - Browse repository at this point
Copy the full SHA 8b33a07View commit details -
chore: revert files that can be cleanup after flag flip
Alex Eagle committedDec 11, 2020 Configuration menu - View commit details
-
Copy full SHA for d0b08d5 - Browse repository at this point
Copy the full SHA d0b08d5View commit details -
fix(builtin): --nobazel_run_linker implies --bazel_patch_module_resolver
If you turn off the linker, you're reverting to earlier rules_nodejs behavior where third-party node modules can only be resolved using the patched require() function that knows where to find them
Alex Eagle committedDec 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 2844c97 - Browse repository at this point
Copy the full SHA 2844c97View commit details -
Alex Eagle committed
Dec 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 532cc2a - Browse repository at this point
Copy the full SHA 532cc2aView commit details