fix(py_wheel): add directories in deterministic order #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
reviewed
Aug 18, 2025
|
|
||
| if os.path.isdir(real_filename): | ||
| directory_contents = os.listdir(real_filename) | ||
| directory_contents = sorted(os.listdir(real_filename)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| directory_contents = sorted(os.listdir(real_filename)) | |
| # listdir() results are unordered; sort for determinism. | |
| directory_contents = sorted(os.listdir(real_filename)) |
rickeylev
approved these changes
Aug 18, 2025
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Aug 19, 2025
…3194) A call to `os.listdir` does not return a deterministic result from one run to the next. So for example if the output of a skylib [copy_directory](https://github.com/bazelbuild/bazel-skylib/blob/main/docs/copy_directory_doc.md) is added to a wheel, the files will be in a random order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
os.listdirdoes not return a deterministic result from one run to the next. So for example if the output of a skylib copy_directory is added to a wheel, the files will be in a random order.