Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Nov 1, 2025

Work towards #2704

@aignas aignas requested a review from rickeylev as a code owner November 1, 2025 16:17
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request experimentally removes support for Python 3.8 by updating the version definitions. The primary goal is to assess what components or tests might break as a result of dropping this specific minor version, in preparation for potential future deprecation. This change impacts the available Python versions for builds and ensures that the system no longer references Python 3.8.

Highlights

  • Python 3.8 Version Removal: The entry for Python version '3.8.20' has been removed from the TOOL_VERSIONS dictionary, which specifies download URLs and SHA256 hashes for various Python builds.
  • Minor Version Mapping Update: The mapping for Python '3.8' to '3.8.20' has been removed from the MINOR_MAPPING dictionary, indicating that Python 3.8 is no longer considered a supported minor version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request begins the process of dropping Python 3.8 support by removing its definitions from python/versions.bzl. The changes correctly remove the 3.8.20 version from TOOL_VERSIONS and the 3.8 mapping from MINOR_MAPPING. These changes are correct and align with the PR's goal.

As this is an experiment to see what breaks, other areas to investigate will be CI configurations for Python 3.8 and any remaining 3.8-specific files. I also noticed an example in a comment in python/versions.bzl (lines 40-51) that still uses Python 3.8.10; updating this to a supported version would be a good follow-up to avoid confusion.

@aignas
Copy link
Collaborator Author

aignas commented Nov 1, 2025

hmmm, it looks like the situation is the same, I guess we need to start bumping the rules_protobuf or others to ensure that the 3.8 references are no longer there.

@aignas aignas requested a review from dougthor42 as a code owner November 1, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant