forked from bazel-xcode/xchammer
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source_output_file_map_aspect and DataStore symlink logic #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2022
jerrymarino
reviewed
Oct 18, 2022
jerrymarino
reviewed
Oct 18, 2022
jerrymarino
reviewed
Oct 18, 2022
jerrymarino
reviewed
Oct 18, 2022
jerrymarino
reviewed
Nov 2, 2022
jerrymarino
reviewed
Nov 2, 2022
jerrymarino
reviewed
Nov 2, 2022
jerrymarino
reviewed
Nov 2, 2022
jerrymarino
reviewed
Nov 2, 2022
jerrymarino
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM besides minor edit to type / inline comment. I'd suggest to consider looking at the encapsulation of this logic into the other program but possibly as a followup since you have it working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.o
file underbazel-out
) to existing aspect implemented inBazelExtensions/xcode_configuration_provider.bzl
XCHammerAssets/bazel_build_service_setup.sh
to setup many things necessary to setup the build service changes implemented here: Parse source to output file map from aspect outputgroup JSON files jerrymarino/xcbuildkit#49bazel_build_service_config
attr to allow one to configure the build servicexcbuildkit
config file on the flyTulsi
to pick up latest fixes there (this, this)