Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_output_file_map_aspect and DataStore symlink logic #33

Merged
merged 10 commits into from
Nov 4, 2022

Conversation

thiagohmcruz
Copy link

@thiagohmcruz thiagohmcruz commented Oct 18, 2022

  • Collect mapping information (from source code to respective .o file under bazel-out) to existing aspect implemented in BazelExtensions/xcode_configuration_provider.bzl
  • Adds XCHammerAssets/bazel_build_service_setup.sh to setup many things necessary to setup the build service changes implemented here: Parse source to output file map from aspect outputgroup JSON files jerrymarino/xcbuildkit#49
  • Adds bazel_build_service_config attr to allow one to configure the build service
  • Load build service configurations in Xcode so the new pre build script introduced here can update the xcbuildkit config file on the fly
  • Bump Tulsi to pick up latest fixes there (this, this)

Copy link
Collaborator

@jerrymarino jerrymarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM besides minor edit to type / inline comment. I'd suggest to consider looking at the encapsulation of this logic into the other program but possibly as a followup since you have it working

@thiagohmcruz thiagohmcruz merged commit 7ef4e81 into rules-ios-xchammer Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants