Track files replaced by move #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Alternative approach: run the build, then drop and re-add all watches. This usually gives enough time for the file to re-appear. |
achew22
reviewed
Jun 6, 2017
ibazel/main.go
Outdated
| @@ -59,6 +59,25 @@ ibazel build //path/to/my/buildable:target | |||
| `) | |||
| } | |||
|
|
|||
| type SourceEventProcessor struct { | |||
There was a problem hiding this comment.
Can you move this into its own file?
ibazel/main.go
Outdated
| SourceFileWatcher *fsnotify.Watcher | ||
| } | ||
|
|
||
| func (s SourceEventProcessor) Listen() { |
There was a problem hiding this comment.
Can you add a method that creates a SourceEventProcessor and creates the channel then calls
go s.Listen()
ibazel/main.go
Outdated
| @@ -107,7 +132,7 @@ func main() { | |||
| switch state { | |||
| case WAIT: | |||
| select { | |||
| case <-sourceFileWatcher.Events: | |||
| case <-sourceFileEvents: | |||
There was a problem hiding this comment.
Can you refer to the channel as being attached to the object instead of in the function scope?
clintharrison
pushed a commit
to clintharrison/bazel-watcher
that referenced
this pull request
Sep 28, 2018
This test reproduces the write behavior of vim with `backupcopy` set to both `yes` and `no`. `yes` is the default on Linux, and bazelbuild#10 fixed this case. Unforunately, on macOS, `yes` is not the default, and using `no` will cause ibazel to stop watching the file after a single file save when a kqueue-based file watcher is used.
clintharrison
pushed a commit
to clintharrison/bazel-watcher
that referenced
this pull request
Sep 28, 2018
This test reproduces the write behavior of vim with `backupcopy` set to both `yes` and `no`. `yes` is the default on Linux, and bazelbuild#10 fixed this case. Unforunately, on macOS, `yes` is not the default, and using `no` will cause ibazel to stop watching the file after a single file save when a kqueue-based file watcher is used.
achew22
pushed a commit
that referenced
this pull request
Sep 30, 2018
* Add test reproducing vim backupcopy=no and kqueue failure This test reproduces the write behavior of vim with `backupcopy` set to both `yes` and `no`. `yes` is the default on Linux, and #10 fixed this case. Unforunately, on macOS, `yes` is not the default, and using `no` will cause ibazel to stop watching the file after a single file save when a kqueue-based file watcher is used. * Readd files when they are moved to overcome limitations in kqueue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a watch back to any file that has been replaced by a move. We look for a fsnotify.Remove event and retry watcher.Add() until it returns an error code of 0. Once a max number of retries has been exceeded, it is assumed that the file was removed.
Fixes: #9