Add test reproducing vim backupcopy=no and kqueue failure #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test reproduces the write behavior of vim with
backupcopy
set to bothyes
andno
.yes
is the default on Linux, and #10 fixed this case. Unforunately, on macOS,yes
is not the default, and usingno
will cause ibazel to stop watching the file after a single file save when a kqueue-based file watcher is used. This is described in further detail in #117.The fix for this might actually be the approach first used in #10 except for the
Rename
event, not justRemove
(that is, waiting for vim to finish writing to the new file and re-adding the watcher on the original filename).Otherwise, we may need to switch to an FSEvents-based implementation on macOS, which would require some upstream work on https://github.com/fsnotify/fsevents or waiting for fsnotify/fsnotify#11 to be finished.