From 5a708f96fb91c617acd1a156413866772808ac14 Mon Sep 17 00:00:00 2001 From: Googler Date: Mon, 24 Jul 2023 04:33:53 -0700 Subject: [PATCH] Remove duplicate code. createSkyframeExecutor already calls injectExtraPrecomputedValues, so setUpSkyframe shouldn't need to call it a second time. PiperOrigin-RevId: 550516525 Change-Id: I43556c49eff95b82111fe7f0f234ebfb9816b32a --- .../build/lib/packages/util/PackageLoadingTestCase.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/test/java/com/google/devtools/build/lib/packages/util/PackageLoadingTestCase.java b/src/test/java/com/google/devtools/build/lib/packages/util/PackageLoadingTestCase.java index 01f4aa13af9878..5e1bd72ce1d41f 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/util/PackageLoadingTestCase.java +++ b/src/test/java/com/google/devtools/build/lib/packages/util/PackageLoadingTestCase.java @@ -149,10 +149,6 @@ protected void setUpSkyframe(RuleVisibility defaultVisibility) { packageOptions.defaultVisibility = defaultVisibility; packageOptions.showLoadingProgress = true; packageOptions.globbingThreads = GLOBBING_THREADS; - skyframeExecutor.injectExtraPrecomputedValues( - ImmutableList.of( - PrecomputedValue.injected( - RepositoryDelegatorFunction.RESOLVED_FILE_INSTEAD_OF_WORKSPACE, Optional.empty()))); skyframeExecutor.preparePackageLoading( new PathPackageLocator( outputBase,