From 6cd6294aac851a7cd5c1cfff6e4421ac12d75f85 Mon Sep 17 00:00:00 2001 From: Laszlo Csomor Date: Wed, 13 Feb 2019 08:29:03 +0100 Subject: [PATCH] Add more test cases. --- src/tools/launcher/util/launcher_util_test.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tools/launcher/util/launcher_util_test.cc b/src/tools/launcher/util/launcher_util_test.cc index efc45d9d283047..0195e5eb51949d 100644 --- a/src/tools/launcher/util/launcher_util_test.cc +++ b/src/tools/launcher/util/launcher_util_test.cc @@ -258,10 +258,13 @@ TEST_F(LaunchUtilTest, WindowsEscapeArgTest) { // - second: expected WindowsEscapeArg-encoded string {L"foo", L"foo"}, {L"", L"\"\""}, + {L" ", L"\" \""}, {L"foo\\bar", L"foo\\bar"}, {L"C:\\foo\\bar\\", L"C:\\foo\\bar\\"}, // TODO(laszlocsomor): fix WindowsEscapeArg to use correct escaping - // semantics (not Bash semantics) and add more tests. + // semantics (not Bash semantics) and add more tests. The example below is + // escaped incorrectly. + // {L"C:\\foo bar\\", L"\"C:\\foo bar\\\""}, }); }