diff --git a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java index ab98b38f460358..b0240784235719 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java +++ b/src/main/java/com/google/devtools/build/lib/packages/WorkspaceGlobals.java @@ -50,7 +50,7 @@ public class WorkspaceGlobals implements WorkspaceGlobalsApi { // Must start with a letter and can contain letters, numbers, underscores and hyphens. - private static final Pattern LEGAL_WORKSPACE_NAME = Pattern.compile("^\\p{Alpha}[\\w-]*$"); + private static final Pattern LEGAL_WORKSPACE_NAME = Pattern.compile("^\\p{Alpha}[-.\\w]*$"); private final boolean allowOverride; private final RuleFactory ruleFactory; diff --git a/src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java b/src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java index 7d1e67634a9b20..c153fd45ddc85f 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java +++ b/src/test/java/com/google/devtools/build/lib/packages/WorkspaceFactoryTest.java @@ -53,8 +53,8 @@ public void testWorkspaceStartsWithNumber() throws Exception { @Test public void testWorkspaceWithIllegalCharacters() throws Exception { - helper.parse("workspace(name = 'a.b.c')"); - assertThat(helper.getParserError()).contains("a.b.c is not a legal workspace name"); + helper.parse("workspace(name = 'a+b+c')"); + assertThat(helper.getParserError()).contains("a+b+c is not a legal workspace name"); } @Test