Skip to content

Commit

Permalink
Increase visibility on node methods for internal use cases.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 224740251
  • Loading branch information
Googler authored and Copybara-Service committed Dec 10, 2018
1 parent ba6fdb9 commit d6eb5de
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ && getNumOfGroupsInLastBuildDirectDeps() == dirtyDirectDepIndex) {
* <p>Changes in direct deps do <i>not</i> force this to return false. Only the value is
* considered.
*/
final boolean unchangedFromLastBuild(SkyValue newValue) throws InterruptedException {
public final boolean unchangedFromLastBuild(SkyValue newValue) throws InterruptedException {
checkFinishedBuildingWhenAboutToSetValue();
return !(newValue instanceof NotComparableSkyValue) && getLastBuildValue().equals(newValue);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,13 @@ public synchronized Set<SkyKey> setValue(SkyValue value, Version version)
}

/**
* Returns {@code true} if this node is eligible to be change pruned when its value has not
* Returns {@code true} if this node is eligible to be change-pruned when its value has not
* changed from the last build.
*
* <p>Implementations need not check whether the value has changed - this will only be called if
* the value has not changed.
* <p>Implementations need not check whether the value has changed - nodes will only be
* change-pruned if the value has not changed.
*/
protected boolean isEligibleForChangePruning() {
public boolean isEligibleForChangePruning() {
return true;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ public void ineligibleForPruning() throws InterruptedException {
NodeEntry entry =
new InMemoryNodeEntry() {
@Override
protected boolean isEligibleForChangePruning() {
public boolean isEligibleForChangePruning() {
return false;
}
};
Expand Down

0 comments on commit d6eb5de

Please sign in to comment.