Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load() does not work in WORKSPACE file #337

Closed
lberki opened this issue Jul 28, 2015 · 13 comments
Closed

load() does not work in WORKSPACE file #337

lberki opened this issue Jul 28, 2015 · 13 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request

Comments

@lberki
Copy link
Contributor

lberki commented Jul 28, 2015

Assigning to Damien because he was planning to work on Skylark support for WORKSPACE files.

@damienmg damienmg changed the title include() does not work in WORKSPACE file load() does not work in WORKSPACE file Jul 28, 2015
@damienmg damienmg added type: feature request P2 We'll consider working on this in future. (Assignee optional) labels Jul 28, 2015
@damienmg
Copy link
Contributor

Ok as talked offline, will be resolved by the skylark remote repository. I will pass over all the bug related to it and consolidate them when I have a bit more time

@mrdomino
Copy link
Contributor

Any updates on this? It'd be helpful for my purposes.

@damienmg
Copy link
Contributor

I will start working on that this week or next week. The prototype is
already out there at
https://github.com/damienmg/bazel/tree/skylark-remote-repository?files=1

On Mon, Sep 14, 2015, 9:00 PM Steven Dee notifications@github.com wrote:

Any updates on this? It'd be helpful for my purposes.


Reply to this email directly or view it on GitHub
#337 (comment).

@damienmg
Copy link
Contributor

damienmg commented Oct 9, 2015

Ok I haven't finished my first change and I am going to be out for 4 weeks so this will be delayed. Sorry for that.

@chin33z
Copy link

chin33z commented Nov 11, 2015

Any updates? Really need this feature! Thanks.

@damienmg
Copy link
Contributor

Sorry I am back from a 4 weeks leave and I had to work on some emergency
stuff I should restart working on that tomorrow. The problem is that since
I did my initial prototype a lot have change in the Skylark environment and
I have to handle the change.

On Wed, Nov 11, 2015, 2:45 AM David Hu notifications@github.com wrote:

Any updates? Really need this feature! Thanks.


Reply to this email directly or view it on GitHub
#337 (comment).

@lberki
Copy link
Contributor Author

lberki commented Nov 11, 2015

@damienmg: let me know if I can help -- this is quite an important feature and I'm willing to spend time on it :)

@damienmg
Copy link
Contributor

Sure :) I am starting again to work on it right now.

@chin33z
Copy link

chin33z commented Nov 26, 2015

Just curious, will this feature come independently before "P1. Custom remote repositories using Skylark" finish? I think the two were relative but still independent from user aspect.
Thanks.

@damienmg
Copy link
Contributor

Yes this feature is the first step of the custom remote repositories so it will be available first. I am still having issues with making it work with the environment change but that shouldn't be too long until this is rolled-out.

@benley
Copy link
Contributor

benley commented Dec 1, 2015

yessssssssss thank you

@davidzchen
Copy link
Member

Woohoo! \o/

@chin33z
Copy link

chin33z commented Dec 1, 2015

THANKS!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request
Projects
None yet
Development

No branches or pull requests

6 participants