Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate name in maven_jar does not report error #588

Closed
johnynek opened this issue Nov 11, 2015 · 2 comments
Closed

duplicate name in maven_jar does not report error #588

johnynek opened this issue Nov 11, 2015 · 2 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@johnynek
Copy link
Member

I had something like this:

hadoop_version = "2.5.0"
 maven_jar( name = "hadoop-client", artifact = "org.apache.hadoop:hadoop-mapreduce-client-core:%s" % hado    op_version)
 maven_jar( name = "hadoop-client", artifact = "org.apache.hadoop:hadoop-common:%s" % hadoop_version)

from a copy/paste error. It was a while before I noticed that the second name seemed to be shadowing the first.

I think this should be a warning at least, but I'd prefer it be an error.

@kchodorow
Copy link
Contributor

We actually allow this intentionally, since their are some external repositories used internally (e.g., @bazel-tools and @local-jdk) that we want users to be able to override in their own WORKSPACE file. However, perhaps we could make it an error for it to show up more than once in a given file.

@damienmg damienmg added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 30, 2015
@kchodorow kchodorow added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Jun 14, 2016
@dslomov dslomov added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed category: extensibility > external repositories labels Mar 21, 2019
@jin
Copy link
Member

jin commented May 27, 2020

Closing as maven_jar has been removed.

@jin jin closed this as completed May 27, 2020
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

7 participants