Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing WORKSPACE maven_jar name mappings does not invalidate state #589

Closed
johnynek opened this issue Nov 11, 2015 · 3 comments
Closed
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug

Comments

@johnynek
Copy link
Member

After an error like #588 I had to do a bazel clean to fix the state.

Seems like a change to WORKSPACE should be detected, and if any of the names map to new jars the old external jars should be removed.

@damienmg damienmg added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 30, 2015
@johnynek
Copy link
Member Author

johnynek commented Dec 2, 2015

I'm a bit worried that this bug could be more serious with this:

The fix for #337
8ca065c

I didn't see any tests that made sure that when a macro changes that we invalidate the workspace correctly.

/cc @damienmg

@damienmg
Copy link
Contributor

damienmg commented Dec 2, 2015

Lukacs recently fix that I believe (this bug I mean), can you confirm?

The skylark dependency is added correctly (we share the code for the build file) but you are right we should add a test, see #672

@kchodorow
Copy link
Contributor

Closing as this should have been fixed by recent changes, please comment if it's still and issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Projects
None yet
Development

No branches or pull requests

4 participants