Do not fail or print errors when Shellzelisk cannot find a requested … #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bazel binary, if tools/bazel exists. Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion. This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users.
laurentlb
pushed a commit
that referenced
this pull request
Jan 29, 2020
?Bazel binary, if tools/bazel exists. Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion. This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users. @laurentlb This is the cherry-pick I mentioned. I will import it, if you LGTM this PR. @Helcaraxan @davido FYI. Closes #10664. PiperOrigin-RevId: 291904662
laurentlb
pushed a commit
that referenced
this pull request
Jan 30, 2020
?Bazel binary, if tools/bazel exists. Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion. This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users. @laurentlb This is the cherry-pick I mentioned. I will import it, if you LGTM this PR. @Helcaraxan @davido FYI. Closes #10664. PiperOrigin-RevId: 291904662
laurentlb
pushed a commit
that referenced
this pull request
Jan 30, 2020
?Bazel binary, if tools/bazel exists. Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion. This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users. @laurentlb This is the cherry-pick I mentioned. I will import it, if you LGTM this PR. @Helcaraxan @davido FYI. Closes #10664. PiperOrigin-RevId: 291904662
philwo
added a commit
that referenced
this pull request
Feb 13, 2020
?Bazel binary, if tools/bazel exists. Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion. This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users. @laurentlb This is the cherry-pick I mentioned. I will import it, if you LGTM this PR. @Helcaraxan @davido FYI. Closes #10664. PiperOrigin-RevId: 291904662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Bazel binary, if tools/bazel exists.
Instead, we should do our best to populate the $BAZEL_REAL env var with some meaningful path, but then delegate to tools/bazel without aborting or printing anything, in case we couldn't find a requested binary or make sense of the contents of .bazelversion.
This is in response to #10356 (comment) and hopefully fixes the use case reported by the affected users.
@laurentlb This is the cherry-pick I mentioned. I will import it, if you LGTM this PR.
@Helcaraxan @davido FYI.