Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix label_flag and label_setting to not have a dependency on the default #13667

Closed
wants to merge 2 commits into from
Closed

[WIP] Fix label_flag and label_setting to not have a dependency on the default #13667

wants to merge 2 commits into from

Commits on Jul 13, 2021

  1. Add required_providers attribute to Starlark defined aspects. 

    `required_providers` attribute allows the aspect to limit its propagation to only the targets whose rules advertise the required providers. It accepts a list of either providers or providers lists. To make some rule targets visible to an aspect, the rule must advertise all providers from at least one of the lists specified in the aspect `required_providers`.

This CL also adds incompatible flag `incompatible_top_level_aspects_require_providers` which when set allows the top level aspects to only run on top level targets that advertise its required providers. It is needed to avoid breaking existing usages on command line aspects on targets not advertising its required providers.

PiperOrigin-RevId: 373738497
    @mai93 @katre
    mai93 authored and katre committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    7aabbe9 View commit details
    Browse the repository at this point in the history

  2. Fix label_flag and label_setting to not have a dependency on the default 

    value.

This prevents an extra analysis, since the dependency should only be on
the value being used.

Fixes bazelbuild#11291.

Closes bazelbuild#13372.

PiperOrigin-RevId: 369445041
    @katre
    katre committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    15e700e View commit details
    Browse the repository at this point in the history