Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Fix non-declared symlink issue for local actions when BwoB. #18817

Merged
merged 2 commits into from
Jun 30, 2023
Merged

[6.3.0] Fix non-declared symlink issue for local actions when BwoB. #18817

merged 2 commits into from
Jun 30, 2023

Commits on Jun 29, 2023

  1. Fix non-declared symlink issue for local actions when BwoB. 

    When prefetching non-declared symlink for local actions, we want to download the target artifact if they haven't been downloaded.

Currently, the code use `path.getRelativePath(path.readSymbolicLink())` to mimic resolving relative symlink which is not correct. Replacing it with `path.readSymbolicLink()`.

Fixes bazelbuild#18772.

PiperOrigin-RevId: 544331900
Change-Id: Ie2a6bac298ab9f81e44d5f505f1b3d83519ba3ca
    @coeuvre @iancha1992
    coeuvre authored and iancha1992 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    054dea4 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Merge branch 'release-6.3.0' into cp18772

    @iancha1992
    iancha1992 authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    5d80406 View commit details
    Browse the repository at this point in the history