Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "WindowsFileSystem: open files with delete-sharing" #6732

Closed
wants to merge 1 commit into from
Closed

Revert "WindowsFileSystem: open files with delete-sharing" #6732

wants to merge 1 commit into from

Conversation

meteorcloudy
Copy link
Member

This reverts commit 1a95502.

Related: #6731

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Nov 21, 2018 •
edited
Loading

Could you please add the command you used in creating the rollback? I'm not familiar with git's revert options. Was it a clean rollback or did you have to edit anything? (The original commit was merged a couple of months ago, the code may have changed.)

@meteorcloudy
Copy link
Member Author

Unfortunately this is not a clean rollback. I did git revert 1a95502 then manually edited AbstractFileSystem.java to the state of the parent of 1a95502.

@bazel-io bazel-io closed this in d2920e3 Nov 27, 2018
dslomov pushed a commit that referenced this pull request Nov 28, 2018
@meteorcloudy @dslomov
Revert "WindowsFileSystem: open files with delete-sharing"
f3c6ce8 
This reverts commit 1a95502.

Related: #6731

Closes #6732.

PiperOrigin-RevId: 222958770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor approved these changes

@philwo philwo Awaiting requested review from philwo

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meteorcloudy @laszlocsomor @googlebot