Complete channel initialization in the event loop #7509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If addLast is called outside an event loop, then the handler is added in the 'pending' state. Sending an event to the pipeline does not send it to the last handler, but to the last _non-pending_ handler. We therefore have to make sure to involve the event loop _before_ marking the channel as ready to be used. Thanks to @Reflexe who pointed me in the right direction. Fixes bazelbuild#7464.
ulfjack
requested review from
buchgr,
ola-rozenfeld and
philwo
as code owners
meisterT
approved these changes
Feb 22, 2019
meteorcloudy
approved these changes
Feb 22, 2019
|
Maybe this PR also fixes #7505? |
|
I ran it 15 times with my patch and I didn't see a hang. |
|
Cool, then please also add "fixes #7505" in the description. |
laurentlb
pushed a commit
that referenced
this pull request
Feb 22, 2019
If addLast is called outside an event loop, then the handler is added in the 'pending' state. Sending an event to the pipeline does not send it to the last handler, but to the last _non-pending_ handler. We therefore have to make sure to involve the event loop _before_ marking the channel as ready to be used. Thanks to @Reflexe who pointed me in the right direction. Fixes #7464. Closes #7509. GERRIT_CHANGE_ID= PiperOrigin-RevId: 235184010
|
Great catch @ulfjack and @Reflexe! Netty's channel pool seems to pick a random [1] event loop at initialization where it runs all channel pool tasks on. In the case of the HttpBlobStore this will be true 50% of the time (we have 2 event loops). In this code I was wrongly assuming that the returned Future always runs its listeners on the eventloop of the acquired channel. |
laurentlb
pushed a commit
that referenced
this pull request
Feb 28, 2019
If addLast is called outside an event loop, then the handler is added in the 'pending' state. Sending an event to the pipeline does not send it to the last handler, but to the last _non-pending_ handler. We therefore have to make sure to involve the event loop _before_ marking the channel as ready to be used. Thanks to @Reflexe who pointed me in the right direction. Fixes #7464. Closes #7509. GERRIT_CHANGE_ID= PiperOrigin-RevId: 235184010
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
If addLast is called outside an event loop, then the handler is added in the 'pending' state. Sending an event to the pipeline does not send it to the last handler, but to the last _non-pending_ handler. We therefore have to make sure to involve the event loop _before_ marking the channel as ready to be used. Thanks to @Reflexe who pointed me in the right direction. Fixes #7464. Closes #7509. GERRIT_CHANGE_ID= PiperOrigin-RevId: 235184010
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
If addLast is called outside an event loop, then the handler is added in the 'pending' state. Sending an event to the pipeline does not send it to the last handler, but to the last _non-pending_ handler. We therefore have to make sure to involve the event loop _before_ marking the channel as ready to be used. Thanks to @Reflexe who pointed me in the right direction. Fixes #7464. Closes #7509. GERRIT_CHANGE_ID= PiperOrigin-RevId: 235184010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If addLast is called outside an event loop, then the handler is added in
the 'pending' state. Sending an event to the pipeline does not send it
to the last handler, but to the last non-pending handler. We therefore
have to make sure to involve the event loop before marking the channel
as ready to be used.
Thanks to @Reflexe who pointed me in the right direction.
Fixes #7464.