Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete channel initialization in the event loop #7509

Closed
wants to merge 1 commit into from
Closed

Complete channel initialization in the event loop #7509

wants to merge 1 commit into from

Commits on Feb 22, 2019

  1. Complete channel initialization in the event loop 

    If addLast is called outside an event loop, then the handler is added in
the 'pending' state. Sending an event to the pipeline does not send it
to the last handler, but to the last _non-pending_ handler. We therefore
have to make sure to involve the event loop _before_ marking the channel
as ready to be used.

Thanks to @Reflexe who pointed me in the right direction.

Fixes bazelbuild#7464.
    @ulfjack
    ulfjack committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    840b83d View commit details
    Browse the repository at this point in the history