-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for using the Microsoft VSO-Hash digest function #84
Conversation
This allows Remote Exec implementations for Microsoft Build Accelerator (https://github.com/Microsoft/BuildXL) to exchange its standard hashes
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
LGTM. Can you please sign the CLA? |
Signed CLA |
@Erikma I believe it didn't work. Did you sign with the same e-mail address as is used in your git commit? |
CLA problems, working on finding the right MS-internal CLA owner. ETA probably a couple of days. |
Retry on CLA |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hey @EdSchouten - You asked about this PR at BazelCon and I thought I'd add to @Erikma's answer :) The pages in the VSO0 hash are used for performance as they are hashed concurrently on a single processor using SIMD operations (e.g. as provided by bcrypt). The blocks can be hashed concurrently on multiple threads or systems. This is super helpful when performing large uploads to a CAS. If you have an X GB file, at no point does any HTTP handler have to hash all X bytes. Each call is only responsible for hashing 2MB. We also have intra-file deduplication. We don't talk about it much (yet!) but it powers Universal Packages and Pipeline Artifacts in Azure DevOps. It's based on https://docs.microsoft.com/en-us/windows-server/storage/data-deduplication/overview so it uses variable-sized blocks. Best way to play with it is to fire up a free DevOps account and tinker with Pipeline Artifacts. You can see the efficacy in the output spew:
|
This allows Remote Exec implementations for Microsoft Build Accelerator (https://github.com/Microsoft/BuildXL) to exchange its standard hashes