Skip to content

Commit

Permalink
Remove implicit_outputs from apple_binary (#1898)
Browse files Browse the repository at this point in the history
This is never used by the rules or anything requesting it. I don't think
the compatibility mentioned here really matters anymore.
  • Loading branch information
keith committed Mar 15, 2023
1 parent efe1388 commit 5f03627
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions apple/apple_binary.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,4 @@ rule is being provided for the purpose of transitioning users from the built-in
implementation of `apple_binary` in Bazel core so that it can be removed.
""",
implementation = _apple_binary_impl,
implicit_outputs = {
# Provided for compatibility with built-in `apple_binary` only.
"lipobin": "%{name}_lipobin",
},
)
2 changes: 0 additions & 2 deletions apple/internal/rule_factory.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,6 @@ def _create_apple_binary_rule(
doc,
additional_attrs = {},
cfg = transition_support.apple_rule_transition,
implicit_outputs = None,
platform_type = None,
product_type = None,
require_linking_attrs = True):
Expand Down Expand Up @@ -1254,7 +1253,6 @@ binaries/libraries will be created combining all architectures specified by
doc = doc,
executable = is_executable,
fragments = ["apple", "cpp", "objc"],
outputs = implicit_outputs,
toolchains = use_cpp_toolchain(),
)

Expand Down

0 comments on commit 5f03627

Please sign in to comment.