Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

toolchains/kubectl/defaults.bzl update #717

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

skyl
Copy link
Contributor

@skyl skyl commented Oct 25, 2022

Feel free to update this PR; I don't know what the other defaults are

@google-cla
Copy link

google-cla bot commented Oct 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link

Hi @skyl. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chases2
Copy link
Contributor

chases2 commented Oct 26, 2022

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, skyl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chases2 chases2 merged commit 75c78d0 into bazelbuild:master Feb 28, 2023
@skyl skyl deleted the patch-1 branch March 5, 2023 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants