Add support for Bzlmod #1006
Add support for Bzlmod #1006
Conversation
Bencodes
requested review from
cgruber,
timpeut and
restingbull
as code owners
.bazelversion
Outdated
| @@ -1 +1 @@ | |||
| 6.1.1 | |||
| 7.0.0-pre.20230724.1 | |||
There was a problem hiding this comment.
Note: I don't think we actually need to be using the latest rolling release here.
|
@Bencodes This means after merging this PR I can set up a Kotlin project with Bzlmod like? Currently, I finding a way to work around with |
|
@dkthezero yes it would. |
|
The bulk of the pre-work has been pulled out into this PR so that we can review it independently. |
Bencodes
force-pushed
the
add-support-for-bzlmod
branch
from
a23dd05
to
02ad06e
Compare
MODULE.bazel
Outdated
| @@ -0,0 +1,71 @@ | |||
| module( | |||
| name = "io_bazel_rules_kotlin", | |||
There was a problem hiding this comment.
Can you call this just "rules_kotlin"? This is what gets exported to BCR: https://github.com/bazelbuild/bazel-central-registry/tree/main/modules
So "io_bazel_" prefix would be a precedent.
"repo_name = " attribute controls how this can be used, that is what you need in the load statements and as dependencies.
examples/trivial/MODULE.bazel
Outdated
| ) | ||
|
|
||
| bazel_dep(name = "rules_java", version = "6.4.0") | ||
| bazel_dep(name = "io_bazel_rules_kotlin") |
There was a problem hiding this comment.
Should be rules_kotlin with optional repo_name="io_bazel_rules_kotlin".
|
Thanks for your effort! |
| @@ -1,3 +1,5 @@ | |||
| common --enable_bzlmod=true | |||
There was a problem hiding this comment.
Enabling Bzlmod by default for rules_kotlin
| bazel_dep(name = "bazel_skylib", version = "1.3.0") | ||
| bazel_dep(name = "rules_java", version = "6.4.0") | ||
| bazel_dep(name = "rules_python", version = "0.24.0") | ||
| bazel_dep(name = "rules_cc", version = "0.0.8") |
There was a problem hiding this comment.
rules_cc is needed for the remote execution configs.
| ) | ||
|
|
||
| def _extra_repositories(): | ||
| # TODO(bencodes) This really needs to be a development dependency |
There was a problem hiding this comment.
Left a TODO here to move this out into a development dependency. I'll do another pass once this is merged to get these dependencies into better shape so that we can do a production-ready release of rules_kotlin.
Adding support for Bzlmod now that Android is unblocked. What's included in this PR:
examples/trivialexample to use Bzlmod with abazel_dep(name = "rules_java", version = "...")with alocal_path_override. It's worth noting that this does not yet exercise the release binary that we distribute for releases.rules_kotlin(excluding the examples)This PR is largely based on the work that @comius did in #902.
#660