Add Android Platforms build flags. #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Oct 13, 2023
| @@ -88,3 +88,5 @@ http_archive( | |||
| load("@robolectric//bazel:robolectric.bzl", "robolectric_repositories") | |||
|
|
|||
| robolectric_repositories() | |||
|
|
|||
| android_ndk_repository(name = "androidndk") | |||
There was a problem hiding this comment.
Is the NDK a requirement now?
There was a problem hiding this comment.
Before enabling --incompatible_enable_android_toolchain_resolution, this was using the default (and useless) cc_toolchain from bazel's CC autodetection.
Since that's no longer appropriate (it claims armeabi-v7a, I don't know if the cc compiler in this image can actually do this), it seemed better to at least accurately declare that every Android binary needs an NDK for analysis. If you don't have any actual cc_library dependencies it isn't used (which is why the old one worked).
Ideally the Android rules would not require a CC toolchain if it's not being used, but currently they are.
|
@Bencodes Any further comments? |
Bencodes
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bazelbuild/bazel#16285.