Restrict unecessary inputs to 'JdepsMerge' actions #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviernotteghem
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
Bencodes
approved these changes
May 24, 2024
Bencodes
reviewed
May 24, 2024
| # For sandboxing to work, and for this action to be deterministic, the compile jars need to be passed as inputs | ||
| inputs = depset(jdeps, transitive = [depset([], transitive = [dep.transitive_compile_time_jars for dep in deps])]) | ||
| inputs = depset(jdeps) | ||
| if not toolchains.kt.experimental_report_unused_deps == "off": |
There was a problem hiding this comment.
This should be safe to merge since internally the JdepsMerge action skips resolving the jars and their target labels when this flag is set to off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress JDepsMerge action re-execution in incremental build when dependencies API changes.