Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use placeholders in progress messages #895

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 17, 2022

This allows Bazel to render the labels in progress messages in a more user-friendly way by unmapping mapped repository names to the names used by the main repository, which is especially relevant with Bzlmod.

This allows Bazel to render the labels in progress messages in a more
user-friendly way by unmapping mapped repository names to the names used
by the main repository, which is especially relevant with Bzlmod.
@restingbull
Copy link
Collaborator

Where is the documentation on this?

@restingbull restingbull self-assigned this Dec 18, 2022
@fmeum
Copy link
Contributor Author

fmeum commented Dec 19, 2022

It's documented in https://bazel.build/rules/lib/actions#run (see the progress_message parameter) and has been added in bazelbuild/bazel@bfa3643, which means that it is available in Bazel 5.0.0 and later.

@Bencodes
Copy link
Collaborator

which means that it is available in Bazel 5.0.0 and later.

@fmeum what happens on versions prior to 5.x? Would we need to bump the minimum supported version of rules_kotlin up to 5.x, dropping 4.x?

@fmeum
Copy link
Contributor Author

fmeum commented Dec 22, 2022

@Bencodes With Bazel 4, users would see the literal string %{label} instead of the label. Given that Bazel 6 is out now, it may be a good time to raise the minimum version, but not if this PR is the only reason to do so. It isn't fixing an important issue, just making progress messages a little nicer with Bazel 6 as well as Bzlmod.

@Bencodes
Copy link
Collaborator

@Bencodes With Bazel 4, users would see the literal string %{label} instead of the label. Given that Bazel 6 is out now, it may be a good time to raise the minimum version, but not if this PR is the only reason to do so. It isn't fixing an important issue, just making progress messages a little nicer with Bazel 6 as well as Bzlmod.

I'm not against dropping support for 4.x after we cut a final 1.7.0 release of rules_kotlin, which we can do this week.

@restingbull
Copy link
Collaborator

Will need to announce bzl 4 removal.

@Bencodes
Copy link
Collaborator

Bencodes commented Jan 6, 2023

#903 (comment)

@Bencodes Bencodes merged commit 0815bbc into bazelbuild:master Jan 6, 2023
@fmeum fmeum deleted the lazy-progress branch January 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants