Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rules_proto calls for deps, etc. #904

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

restingbull
Copy link
Collaborator

Changes

  • Download rules_proto dependencies
  • Fix shas in rules_proto dependencies as the new version is broken
  • Update rules_python for the new rules_pkg
  • Some steps to simplify version management.

Notes

  • We can probably remove the python dependency entirely -- it appears to do some small archive manipulation. that toolchain needs some love.
  • Hey, ho, rules_proto has got to go! We should move to json for the worker chatter and away from the using it as a compilation model.

@restingbull restingbull force-pushed the restingbull/fix-rules_pkg-python branch 2 times, most recently from 26ca496 to 8f8d431 Compare December 22, 2022 22:25
@Bencodes
Copy link
Collaborator

Hey, ho, rules_proto has got to go! We should move to json for the worker chatter and away from the using it as a compilation model.

I can probably take a look at this. It's not super hard to migrate over. We'll just need to have people flip the flag on Bazel 4 (unless we drop it).

@restingbull restingbull force-pushed the restingbull/fix-rules_pkg-python branch 2 times, most recently from 24b9b92 to fe5c1c7 Compare December 23, 2022 04:09
Simplify version management.
@restingbull restingbull force-pushed the restingbull/fix-rules_pkg-python branch from fe5c1c7 to db19e99 Compare December 23, 2022 04:13
@restingbull restingbull merged commit e5c457c into master Dec 23, 2022
@restingbull restingbull deleted the restingbull/fix-rules_pkg-python branch December 23, 2022 23:00
Bencodes pushed a commit that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants