Fix reference to java_infos in compile.bzl #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compile.bzl` was incorrectly referencing `java_info` instead of `java_infos` in cases where annotation processors were found, causing compilation to fail with an opaque error (bazelbuild#877). This fixes the reference.
avarun42
requested review from
cgruber,
timpeut and
restingbull
as code owners
Fixing the typo resulted in the following error: ``` Traceback (most recent call last): File "/workdir/kotlin/internal/jvm/impl.bzl", line 219, column 36, in kt_jvm_library_impl _kt_jvm_produce_jar_actions(ctx, "kt_jvm_library") if ctx.attr.srcs or ctx.attr.resources else export_only_providers( File "/workdir/kotlin/internal/jvm/compile.bzl", line 493, column 50, in kt_jvm_produce_jar_actions outputs_struct = _run_kt_java_builder_actions( File "/workdir/kotlin/internal/jvm/compile.bzl", line 751, column 66, in _run_kt_java_builder_actions ap_class_jar = [jars.class_jar for jars in java_infos.outputs.jars][0], Error: 'list' value has no field or method 'outputs' ``` `java_infos` is a list and thus doesn't have an `outputs` field, but each `java_info` inside the list does. Thus replacing `java_infos.outputs.jars` with the list comprehension `[java_info.outputs.jars for java_info in java_infos]` gets us a list of `jars` objects that can be used in the outer list comprehension.
|
Oh, facepalm. It didn't fail more often because of https://github.com/bazelbuild/rules_kotlin/blob/master/kotlin/internal/jvm/compile.bzl#L694. I hate that about python scoping. |
restingbull
approved these changes
Jan 13, 2023
|
Ah yes I was wondering why the tests only started failing after changing the reference. Python scoping is... not the greatest. Any ETA on when a 1.7.2 can be cut with the fix? |
|
bump on getting this fix released — we're currently unable to use any version of this package starting from 1.6.0 due to this bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile.bzlwas incorrectly referencing the variablejava_infoin cases where annotation processors were found, causing compilation to fail as this variable had not been assigned yet. We must first get theoutputsfrom eachjava_infoinsidejava_infos, and then use a nested list comprehension to get thejarslist from eachoutputs, flatten the resulting list, and get theclass_jarfield of eachjarsobject inside the flattened list.Fixes #877