Add support for KSP annotation processing via KspCompile #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for this to land so that we can properly find runfiles #956 |
Bencodes
force-pushed
the
add-support-for-ksp-annotation-processing-via-kspcompile
branch
from
b1c4ecb to
6749c40
Compare
Bencodes
force-pushed
the
add-support-for-ksp-annotation-processing-via-kspcompile
branch
from
6749c40 to
3a552f0
Compare
Bencodes
force-pushed
the
add-support-for-ksp-annotation-processing-via-kspcompile
branch
from
d073c82 to
311e727
Compare
Bencodes
commented
Apr 21, 2023
| transitive_runtime_jars = transitive_runtime_jars, | ||
| plugins = plugins, | ||
| outputs = { | ||
| "ksp_generated_java_srcjar": ksp_generated_java_srcjar, |
There was a problem hiding this comment.
This action currently only supports collecting generated Kotlin source files and resources. If a KSP plugin outputs Java or compiled outputs, this action will not collect them up to be used in the downstream actions.
Bencodes
commented
Apr 21, 2023
| "incremental" to listOf("false"), | ||
| // Directory where class files are written to. Files written to this directory are class | ||
| // files being written directly from the annotation processor, not Kotlinc | ||
| "classOutputDir" to listOf(directories.generatedClasses), |
There was a problem hiding this comment.
classOutputDir, javaOutputDir, and javaOutputDir are currently being ignored when written to. We'll need to look into adding support for this incrementally.
restingbull
approved these changes
Apr 21, 2023
| @@ -19,12 +19,23 @@ java_plugin( | |||
| deps = ["@maven//:com_google_auto_value_auto_value"], | |||
| ) | |||
|
|
|||
| kt_ksp_plugin_info( | |||
There was a problem hiding this comment.
Why not kt_ksp_plugin?
There was a problem hiding this comment.
Ah good catch. Renamed this to just kt_ksp_plugin
Bencodes
deleted the
add-support-for-ksp-annotation-processing-via-kspcompile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding proper support for KSP annotation processors.
KSP plugins can be defined and given to targets using the
kt_ksp_pluginrule and can be passed to Kotlin targets in thepluginsattribute.With this approach KSP and Kapt can be used in the same module.
Example: