Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--incompatible_depset_is_not_iterable #79

Closed
laurentlb opened this issue Mar 7, 2019 · 1 comment · Fixed by #83
Closed

--incompatible_depset_is_not_iterable #79

laurentlb opened this issue Mar 7, 2019 · 1 comment · Fixed by #83
Assignees
@alexeagle

Comments

@laurentlb
Copy link
Contributor

rules_sass doesn't work with Bazel flag --incompatible_depset_is_not_iterable.

Result from the CI: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/30#1e6dce1f-3a42-4eb4-88b7-f06f1cdcab7a

File "/var/lib/buildkite-agent/builds/bk-docker-5c9v/bazel-downstream-projects/rules_sass/sass/sass.bzl", line 232, in depset
  [f for t in ctx.attr.srcs for f in t.files]
  type 'depset' is not iterable. Use the `to_list()` method to get a list. Use --incompatible_depset_is_not_iterable=false to temporarily disable this check.

Related documentation: https://docs.bazel.build/versions/master/skylark/depsets.html

Could you take a look at this?
@nex3
Copy link
Collaborator

nex3 commented Mar 8, 2019

Alex, can you take a look at this? It's out of my skylark depth.

@laurentlb laurentlb mentioned this issue Apr 25, 2019
Merged
@nex3 nex3 closed this as completed in #83 Apr 25, 2019
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 25, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
7eeb1b4 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
1a4e224 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
f6c1fac 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
1f8e82d 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
9e078b6 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
9bdb682 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
3e5abd1 
See: bazelbuild/rules_sass#79
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 27, 2019
@guibou
Switch --incompatible_depset_is_not_iterable
893073d 
See: bazelbuild/rules_sass#79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid iteration over a depset laurentlb/rules_sass
3 participants
@nex3 @alexeagle @laurentlb