Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "fritzbox" bucket in dashboards #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deltaphi
Copy link

@deltaphi deltaphi commented May 7, 2024

Update the influxdbv2 dashboards to use the bucket named "fritzbox" (default name used by the script when creating the bucket) instead of requiring the data source default to be set to the fritzinfluxdb bucket. This is really handy if you use the same influxdb/grafana instances for multiple buckets and dashboards.

In case you do not want to accept this pull request, a note in the documentation how to patch the dashboard files would be appreciated.

@bb-Ricardo
Copy link
Owner

Hi,

Thank you for the PR. I still try to understand the issue which this PR meant to solve. The bucket name is a variable which is defined as the default bucket for the defined datasource.

@deltaphi
Copy link
Author

deltaphi commented May 8, 2024

bucket name is a variable which is defined as the default bucket for the defined datasource.

And that’s exactly the problem :) I use another bucket on the same influxdb instance for Home Assistant. I also use the same grafana instance for dashboards related to Home Assistant and Fritzinfluxdb. Add it is the same influxdb instance, I already have the data source set up. But the Home Assistant Dashboard were there first, so the default bucket is already taken up by them.

This patch enables using the same data source for both Home Assistant and Fritzinfluxdb buckets.

@bb-Ricardo
Copy link
Owner

Ahh, that's what I assumed. How about adding an additional dedicated datasource for that purpose?

Should also think about how to progress with this whole influxdb mess.

Have you used VictoriaMetrics?

@deltaphi
Copy link
Author

deltaphi commented May 8, 2024

Ahh, that's what I assumed. How about adding an additional dedicated datasource for that purpose?

I basically expected that the solution would be something as annoying as that. I don't feel like dealing with the Token stuff and figuring out what goes where again, though, so I'm flat out refusing to try when I already have a working solution :D.

I can understand if you don't want to accept this PR - but then maybe adding a hint in the top-level README.md that you can just text-replace the bucket name in the JSON files would be helpful.

Should also think about how to progress with this whole influxdb mess.

Have you used VictoriaMetrics?

Entirely different topic, so maybe a discussion for a different issue? My answer: No, I haven't used VictoriaMetrics. Glancing over the Website, it appears to be similar to InfluxDB: A time series database developed as open source (how open?) in a basic tier and available as paid-for license in a more advanced tier, developed by a for-profit company - just like InfluxDB. Personally, I wouldn't trust them to do any better than InfluxDB does.

Without having done more research than opening like the first hit on google: OpenTSDB appears to be a true open source project - and can also be used as a data source for Grafana.

@bb-Ricardo bb-Ricardo added the blocked-by-InfluxDB-mess First the way forward with InfluxDB needs to be solved - see #114 label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-InfluxDB-mess First the way forward with InfluxDB needs to be solved - see #114
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants