Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong HTTPupload size member semantics #8

Open
everslick opened this issue Nov 3, 2017 · 2 comments
Open

Wrong HTTPupload size member semantics #8

everslick opened this issue Nov 3, 2017 · 2 comments

Comments

@everslick
Copy link

IMHO the semantics of HTTPupload.currentSize and HTTPupload.totalSize are wrong or at least highly misleading.

now we get the size of the last chunk of data in currentSize and the number of bytes received so far in totalSize. But currentSize as it is, is pretty useless and we really want the know how big the file is going to be once complete (for correct progress calculation and for checking filesystem requirements).

i suggest to make currentSize what totalSize is now and put the Content-Length header arg in totalSize.

does this sound reasonable?

@everslick
Copy link
Author

I want to add, this issue is also discussed in the ESP8266 implementation here: esp8266/Arduino#3787. we should just copy whatever the fix will be there.

@skyladle
Copy link

skyladle commented Apr 8, 2018

to @everslick
hi
I have a similar problem like this. it trap me for days. can you help me
lbernstone/setCerts#1
thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants