You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMHO the semantics of HTTPupload.currentSize and HTTPupload.totalSize are wrong or at least highly misleading.
now we get the size of the last chunk of data in currentSize and the number of bytes received so far in totalSize. But currentSize as it is, is pretty useless and we really want the know how big the file is going to be once complete (for correct progress calculation and for checking filesystem requirements).
i suggest to make currentSize what totalSize is now and put the Content-Length header arg in totalSize.
does this sound reasonable?
The text was updated successfully, but these errors were encountered:
I want to add, this issue is also discussed in the ESP8266 implementation here: esp8266/Arduino#3787. we should just copy whatever the fix will be there.
IMHO the semantics of HTTPupload.currentSize and HTTPupload.totalSize are wrong or at least highly misleading.
now we get the size of the last chunk of data in currentSize and the number of bytes received so far in totalSize. But currentSize as it is, is pretty useless and we really want the know how big the file is going to be once complete (for correct progress calculation and for checking filesystem requirements).
i suggest to make currentSize what totalSize is now and put the Content-Length header arg in totalSize.
does this sound reasonable?
The text was updated successfully, but these errors were encountered: