Fixed lease not showing pids on view (#3824)

bcgov · Feb 29, 2024 · d72cb81 · d72cb81
1 parent 18ccd39
commit d72cb81
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/source/frontend/src/features/leases/detail/LeasePages/details/PropertyInformation.tsx b/source/frontend/src/features/leases/detail/LeasePages/details/PropertyInformation.tsx
@@ -6,7 +6,7 @@ import { Input } from '@/components/common/form';
 import { SectionField } from '@/components/common/Section/SectionField';
 import { ApiGen_Base_CodeType } from '@/models/api/generated/ApiGen_Base_CodeType';
 import { ApiGen_Concepts_Lease } from '@/models/api/generated/ApiGen_Concepts_Lease';
-import { formatNumber, isValidString, pidFormatter } from '@/utils';
+import { formatNumber, isValidId, isValidString, pidFormatter } from '@/utils';
 import { withNameSpace } from '@/utils/formUtils';
 
 import AddressSubForm from '../AddressSubForm';
@@ -33,13 +33,13 @@ export const PropertyInformation: React.FunctionComponent<
  withNameSpace(nameSpace, 'areaUnitType'),
  );
 
- const legalDescription = getIn(
+ const legalDescription: string = getIn(
  formikProps.values,
  withNameSpace(nameSpace, 'property.landLegalDescription'),
  );
- const pid = getIn(formikProps.values, withNameSpace(nameSpace, 'property.pid'));
+ const pid: number | null = getIn(formikProps.values, withNameSpace(nameSpace, 'property.pid'));
 
- const pidText = pid ? `PID: ${pidFormatter(pid)}` : '';
+ const pidText = isValidId(pid) ? `PID: ${pidFormatter(pid.toString())}` : '';
  return (
  <StyledPropertyInfo>
  <SectionField label="PID" labelWidth="3">