correct display of error icon, ensure that re-loading an errored page…

… removes the error.
bcgov · May 22, 2024 · efa5c81 · efa5c81
1 parent 04dd142
commit efa5c81
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/source/frontend/package-lock.json b/source/frontend/package-lock.json
diff --git a/source/frontend/package.json b/source/frontend/package.json
@@ -32,7 +32,7 @@
  "react-dom": "18.2.0",
  "react-draggable": "4.4.5",
  "react-error-boundary": "3.1.4",
- "react-icons": "4.11.0",
+ "react-icons": "5.2.1",
  "react-idle-timer": "5.4.2",
  "react-leaflet": "4.2.1",
  "react-number-format": "4.9.3",

diff --git a/source/frontend/src/features/documents/DocumentPreviewContainer.tsx b/source/frontend/src/features/documents/DocumentPreviewContainer.tsx
@@ -46,10 +46,13 @@ export const DocumentPreviewContainer: FC<
  documentFileId: number,
  documentFilePageId: number,
  ): Promise<string> => {
- //todo: handle image failure
- return createFileUrl(
- await downloadDocumentFilePageImage(documentId, documentFileId, documentFilePageId),
+ const blob = await downloadDocumentFilePageImage(
+ documentId,
+ documentFileId,
+ documentFilePageId,
  );
+
+ return createFileUrl(blob);
  },
  [downloadDocumentFilePageImage, createFileUrl],
  );
@@ -135,6 +138,7 @@ export const DocumentPreviewContainer: FC<
  const page = documentPages[currentPage];
  // lazy load the next page, but do not replace lazy loaded data.
  if (previewDocumentId && page && !page.loadedDocumentImageDataUrl) {
+ page.error = undefined;
  loadDocumentPageImageUrl(
  previewDocumentId,
  page.mayanPage.document_file_id,

diff --git a/source/frontend/src/features/documents/hooks/useDocumentProvider.ts b/source/frontend/src/features/documents/hooks/useDocumentProvider.ts
@@ -256,6 +256,7 @@ export const useDocumentProvider = () => {
  }
  return Promise.reject(axiosError);
  }, []),
+ throwError: true,
  });
 
  const { execute: getDocumentFilePageList, loading: getDocumentFilePageListLoading } =