Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull requests report(19/08/2024 21:02) #4274

Open
devinleighsmith opened this issue Aug 19, 2024 · 9 comments
Open

Pull requests report(19/08/2024 21:02) #4274

devinleighsmith opened this issue Aug 19, 2024 · 9 comments

Comments

@devinleighsmith
Copy link
Collaborator

devinleighsmith commented Aug 19, 2024 •
edited
Loading

Pull Request report total

This report based on 588 last updated PRs. To learn more about the project and its configuration, please visit Pull request analytics action.

Below are the settings applied for this report:

GITHUB_OWNERS_REPOS: bcgov/psp
GITHUB_OWNER_FOR_ISSUE: bcgov
GITHUB_REPO_FOR_ISSUE: psp
SHOW_STATS_TYPES: timeline, workload, pr-quality, code-review-engagement, response-time
TOP_LIST_AMOUNT: 5
AGGREGATE_VALUE_METHODS: percentile
PERCENTILE: 75
SHOW_USERS: FuriousLlama,asanchezr,devinleighsmith,eddherrera,stairaku
REPORT_DATE_START: 1/01/2024
REPORT_DATE_END: 31/12/2024
AMOUNT: 100
PERIOD_SPLIT_UNIT: months
EXECUTION_OUTCOME: new-issue

References

Pull requests timeline(75th percentile) total

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 21 hours 37 minutes 16 hours 25 minutes 16 hours 39 minutes 18 hours 94
devinleighsmith 79 hours 28 minutes 22 hours 8 minutes 23 hours 35 minutes 47 hours 4 minutes 233
eddherrera 24 hours 50 minutes 46 hours 25 minutes 51 hours 26 minutes 66
FuriousLlama 119 hours 27 minutes 20 hours 25 minutes 23 hours 50 minutes 45 hours 2 minutes 74
stairaku 19 hours 8 minutes 22 hours 24 minutes 27 hours 27 minutes 38 
gantt
title Pull requests timeline(75th percentile) total / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review request(21 hours 37 minutes) :  0, 1297
Time to review(16 hours 25 minutes) :  0, 985
Time to approve(16 hours 39 minutes) :  0, 999
Time to merge(18 hours) :  0, 1080
        
section devinleighsmith
                Time to review request(79 hours 28 minutes) :  0, 4768
Time to review(22 hours 8 minutes) :  0, 1328
Time to approve(23 hours 35 minutes) :  0, 1415
Time to merge(47 hours 4 minutes) :  0, 2824
        
section eddherrera
                Time to review(24 hours 50 minutes) :  0, 1490
Time to approve(46 hours 25 minutes) :  0, 2785
Time to merge(51 hours 26 minutes) :  0, 3086
        
section FuriousLlama
                Time to review request(119 hours 27 minutes) :  0, 7167
Time to review(20 hours 25 minutes) :  0, 1225
Time to approve(23 hours 50 minutes) :  0, 1430
Time to merge(45 hours 2 minutes) :  0, 2702
        
section stairaku
                Time to review(19 hours 8 minutes) :  0, 1148
Time to approve(22 hours 24 minutes) :  0, 1344
Time to merge(27 hours 27 minutes) :  0, 1647
Loading

longest-pending reviews

  1. Dead code/lint update - read description(521 hours 28 minutes)
  2. SPIKE: Siteminder Refresh(465 hours 21 minutes)
  3. styled modal that warns the user is leaving a form.(457 hours 19 minutes)
  4. psp-7986 update ts version - increment packages with vulnerabilities.(315 hours 32 minutes)
  5. psp-7323 Contact ambiguous(263 hours 26 minutes)

longest-pending approvals

  1. SPIKE: Vite (619 hours 32 minutes)
  2. PSP-8114 : Expose Mayan errors to frontend (temporarily)(484 hours 15 minutes)
  3. Techdebt/use generated document models(461 hours 36 minutes)
  4. PSP-7681 : FT-REG: Browser alerts should be replaced by established modal dialogs(317 hours 15 minutes)
  5. psp-7275 complete a disposition file. psp-7785, psp-7322, psp-7568(259 hours 4 minutes)

longest-pending merge

  1. psp-5703: add unit tests for document sync and repository(3884 hours 34 minutes)
  2. Contact Ambiguous(530 hours 15 minutes)
  3. Psp 8018 refactor property selector, show frontend warning when selecting isretired properties. (do not review until all 5.3 stories/bugs have been removed).(289 hours 55 minutes)
  4. Vitest(192 hours 9 minutes)
  5. psp-7323 Contact ambiguous(174 hours 1 minute)

Contribution stats total

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 98 94 +1213217/-232109 43/12/11/7/25 64 194
devinleighsmith 253 233 +3545938/-596508 137/34/18/7/57 184 186
eddherrera 73 66 +312348/-75693 20/21/12/3/17 271 104
FuriousLlama 80 74 +248583/-90766 22/16/8/12/22 228 115
stairaku 43 38 +17200/-9806 13/5/4/8/13 19 3

Pull request quality total

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 94 0 4 / 0 / 34 38
devinleighsmith 233 3 1 / 0 / 100 120
eddherrera 66 7 0 / 0 / 123 152
FuriousLlama 74 8 6 / 0 / 130 140
stairaku 38 2 0 / 0 / 11 12

The most commented PRs

  1. PSP-7296 : Create/Edit Sales Details (Disposition)(64)
  2. PSP-7500 - UI/UX cleanup agreements create /edit(42)
  3. Tech debt| use new api files and null enhancements(41)
  4. psp-8630 | Updated Leases and added renewals(23)
  5. PSP-8315 : Add Lease and License Checklist(23)

Code review engagement total

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 94 4 / 0 / 78 88 87/43/17/15/32 0 / 34 / 187
devinleighsmith 233 3 / 0 / 205 236 63/31/22/17/53 17 / 57 / 182
eddherrera 66 2 / 0 / 32 35 63/12/6/4/19 1 / 15 / 104
FuriousLlama 74 2 / 0 / 85 107 47/15/13/6/34 3 / 29 / 106
stairaku 38 0 / 0 / 0 0 0/0/2/1/0 0 / 0 / 3

Review Request Response Time(75th percentile) total

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 38 194 18 hours 36 minutes 22 hours 37 minutes
devinleighsmith 52 186 21 hours 25 minutes 25 hours 21 hours 13 minutes
eddherrera 18 104 26 hours 3 minutes 1 hour 3 minutes
FuriousLlama 32 115 30 hours 9 minutes 8 hours 17 minutes 22 hours 28 minutes
stairaku 5 3 5 hours 38 minutes 5 hours 37 minutes
@devinleighsmith
Copy link
Collaborator Author

References

gantt
title Pull request's retrospective timeline(75th percentile) asanchezr / minutes
dateFormat X
axisFormat %s
section 8/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(15 hours 39 minutes) :  0, 939
Time to approve(41 hours 43 minutes) :  0, 2503
Time to merge(44 hours 56 minutes) :  0, 2696
        
section 7/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(16 hours 42 minutes) :  0, 1002
Time to approve(16 hours 42 minutes) :  0, 1002
Time to merge(18 hours 19 minutes) :  0, 1099
        
section 6/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(15 hours 18 minutes) :  0, 918
Time to approve(15 hours 18 minutes) :  0, 918
Time to merge(16 hours 23 minutes) :  0, 983
        
section 5/2024
                Time in draft() :  0, 0
Time to review request(15 hours 8 minutes) :  0, 908
Time to review(15 hours 22 minutes) :  0, 922
Time to approve(15 hours 29 minutes) :  0, 929
Time to merge(18 hours 51 minutes) :  0, 1131
        
section 4/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(15 hours 59 minutes) :  0, 959
Time to approve(16 hours 3 minutes) :  0, 963
Time to merge(17 hours 40 minutes) :  0, 1060
        
section 3/2024
                Time in draft() :  0, 0
Time to review request(19 hours 59 minutes) :  0, 1199
Time to review(12 hours 49 minutes) :  0, 769
Time to approve(12 hours 49 minutes) :  0, 769
Time to merge(13 hours 17 minutes) :  0, 797
        
section 2/2024
                Time in draft() :  0, 0
Time to review request(99 hours 15 minutes) :  0, 5955
Time to review(19 hours 43 minutes) :  0, 1183
Time to approve(19 hours 43 minutes) :  0, 1183
Time to merge(19 hours 54 minutes) :  0, 1194
        
section 1/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(17 hours 24 minutes) :  0, 1044
Time to approve(17 hours 24 minutes) :  0, 1044
Time to merge(19 hours 43 minutes) :  0, 1183
Loading 
gantt
title Pull request's retrospective timeline(75th percentile) devinleighsmith / minutes
dateFormat X
axisFormat %s
section 8/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(18 hours 6 minutes) :  0, 1086
Time to approve(18 hours 21 minutes) :  0, 1101
Time to merge(20 hours 53 minutes) :  0, 1253
        
section 7/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(19 hours 18 minutes) :  0, 1158
Time to approve(19 hours 18 minutes) :  0, 1158
Time to merge(22 hours 50 minutes) :  0, 1370
        
section 6/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(19 hours 49 minutes) :  0, 1189
Time to approve(19 hours 49 minutes) :  0, 1189
Time to merge(22 hours 31 minutes) :  0, 1351
        
section 5/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(18 hours 10 minutes) :  0, 1090
Time to approve(20 hours 45 minutes) :  0, 1245
Time to merge(35 hours 32 minutes) :  0, 2132
        
section 4/2024
                Time in draft() :  0, 0
Time to review request(24 hours 34 minutes) :  0, 1474
Time to review(20 hours 20 minutes) :  0, 1220
Time to approve(20 hours 41 minutes) :  0, 1241
Time to merge(62 hours 56 minutes) :  0, 3776
        
section 3/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(16 hours 39 minutes) :  0, 999
Time to approve(17 hours 47 minutes) :  0, 1067
Time to merge(24 hours 14 minutes) :  0, 1454
        
section 2/2024
                Time in draft() :  0, 0
Time to review request(413 hours 47 minutes) :  0, 24827
Time to review(40 hours 44 minutes) :  0, 2444
Time to approve(40 hours 44 minutes) :  0, 2444
Time to merge(47 hours 34 minutes) :  0, 2854
        
section 1/2024
                Time in draft() :  0, 0
Time to review request(17 hours 4 minutes) :  0, 1024
Time to review(43 hours 38 minutes) :  0, 2618
Time to approve(43 hours 38 minutes) :  0, 2618
Time to merge(68 hours 35 minutes) :  0, 4115
Loading 
gantt
title Pull request's retrospective timeline(75th percentile) eddherrera / minutes
dateFormat X
axisFormat %s
section 8/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(40 minutes) :  0, 40
Time to approve(40 minutes) :  0, 40
Time to merge(1 hour 4 minutes) :  0, 64
        
section 7/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(1 hour 49 minutes) :  0, 109
Time to approve(5 hours 50 minutes) :  0, 350
Time to merge(18 hours 24 minutes) :  0, 1104
        
section 6/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(24 hours 11 minutes) :  0, 1451
Time to approve(52 hours 38 minutes) :  0, 3158
Time to merge(55 hours 27 minutes) :  0, 3327
        
section 5/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(22 hours 58 minutes) :  0, 1378
Time to approve(32 hours 36 minutes) :  0, 1956
Time to merge(33 hours 36 minutes) :  0, 2016
        
section 4/2024
                Time in draft() :  0, 0
Time to review request(23 hours 48 minutes) :  0, 1428
Time to review(38 hours 43 minutes) :  0, 2323
Time to approve(38 hours 45 minutes) :  0, 2325
Time to merge(54 hours 44 minutes) :  0, 3284
        
section 3/2024
                Time in draft() :  0, 0
Time to review request(31 hours 19 minutes) :  0, 1879
Time to review(33 hours 35 minutes) :  0, 2015
Time to approve(74 hours 1 minute) :  0, 4441
Time to merge(74 hours 48 minutes) :  0, 4488
        
section 2/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(9 hours 38 minutes) :  0, 578
Time to approve(23 hours 18 minutes) :  0, 1398
Time to merge(58 hours 53 minutes) :  0, 3533
        
section 1/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(25 hours 58 minutes) :  0, 1558
Time to approve(74 hours 49 minutes) :  0, 4489
Time to merge(89 hours 25 minutes) :  0, 5365
Loading 
gantt
title Pull request's retrospective timeline(75th percentile) FuriousLlama / minutes
dateFormat X
axisFormat %s
section 8/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(2 hours 57 minutes) :  0, 177
Time to approve(2 hours 57 minutes) :  0, 177
Time to merge(15 hours 6 minutes) :  0, 906
        
section 7/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(12 hours 48 minutes) :  0, 768
Time to approve(16 hours 44 minutes) :  0, 1004
Time to merge(17 hours 12 minutes) :  0, 1032
        
section 5/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(23 hours 16 minutes) :  0, 1396
Time to approve(35 hours 28 minutes) :  0, 2128
Time to merge(54 hours 19 minutes) :  0, 3259
        
section 4/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(21 hours 30 minutes) :  0, 1290
Time to approve(24 hours 30 minutes) :  0, 1470
Time to merge(49 hours 18 minutes) :  0, 2958
        
section 3/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(40 hours 37 minutes) :  0, 2437
Time to approve(41 hours 38 minutes) :  0, 2498
Time to merge(45 hours 2 minutes) :  0, 2702
        
section 2/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(2 hours 7 minutes) :  0, 127
Time to approve(2 hours 15 minutes) :  0, 135
Time to merge(5 hours 23 minutes) :  0, 323
        
section 1/2024
                Time in draft(325 hours 19 minutes) :  0, 19519
Time to review request() :  0, 0
Time to review(10 hours 35 minutes) :  0, 635
Time to approve(114 hours 52 minutes) :  0, 6892
Time to merge(144 hours 18 minutes) :  0, 8658
Loading 
gantt
title Pull request's retrospective timeline(75th percentile) stairaku / minutes
dateFormat X
axisFormat %s
section 8/2024
                Time in draft(1 hour 23 minutes) :  0, 83
Time to review request() :  0, 0
Time to review(5 hours 50 minutes) :  0, 350
Time to approve(6 hours 6 minutes) :  0, 366
Time to merge(14 hours 14 minutes) :  0, 854
        
section 7/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(2 hours 9 minutes) :  0, 129
Time to approve(2 hours 9 minutes) :  0, 129
Time to merge(3 hours 38 minutes) :  0, 218
        
section 6/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(22 hours 47 minutes) :  0, 1367
Time to approve(46 hours 47 minutes) :  0, 2807
Time to merge(52 hours 17 minutes) :  0, 3137
        
section 5/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(24 hours 10 minutes) :  0, 1450
Time to approve(24 hours 12 minutes) :  0, 1452
Time to merge(34 hours 28 minutes) :  0, 2068
        
section 4/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(14 hours 55 minutes) :  0, 895
Time to approve(14 hours 55 minutes) :  0, 895
Time to merge(14 hours 57 minutes) :  0, 897
        
section 3/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(9 hours 30 minutes) :  0, 570
Time to approve(9 hours 30 minutes) :  0, 570
Time to merge(28 hours 55 minutes) :  0, 1735
        
section 2/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(1 hour 15 minutes) :  0, 75
Time to approve(1 hour 15 minutes) :  0, 75
Time to merge(2 hours 18 minutes) :  0, 138
        
section 1/2024
                Time in draft() :  0, 0
Time to review request() :  0, 0
Time to review(15 hours 54 minutes) :  0, 954
Time to approve(15 hours 54 minutes) :  0, 954
Time to merge(38 hours 48 minutes) :  0, 2328
Loading

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 8/2024

References

Pull requests timeline(75th percentile) 8/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time in draft Time to review Time to approve Time to merge Total merged PRs
asanchezr 15 hours 39 minutes 41 hours 43 minutes 44 hours 56 minutes 6
devinleighsmith 18 hours 6 minutes 18 hours 21 minutes 20 hours 53 minutes 9
eddherrera 40 minutes 40 minutes 1 hour 4 minutes 3
FuriousLlama 2 hours 57 minutes 2 hours 57 minutes 15 hours 6 minutes 5
stairaku 1 hour 23 minutes 5 hours 50 minutes 6 hours 6 minutes 14 hours 14 minutes 2 
gantt
title Pull requests timeline(75th percentile) 8/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review(15 hours 39 minutes) :  0, 939
Time to approve(41 hours 43 minutes) :  0, 2503
Time to merge(44 hours 56 minutes) :  0, 2696
        
section devinleighsmith
                Time to review(18 hours 6 minutes) :  0, 1086
Time to approve(18 hours 21 minutes) :  0, 1101
Time to merge(20 hours 53 minutes) :  0, 1253
        
section eddherrera
                Time to review(40 minutes) :  0, 40
Time to approve(40 minutes) :  0, 40
Time to merge(1 hour 4 minutes) :  0, 64
        
section FuriousLlama
                Time to review(2 hours 57 minutes) :  0, 177
Time to approve(2 hours 57 minutes) :  0, 177
Time to merge(15 hours 6 minutes) :  0, 906
        
section stairaku
                Time in draft(1 hour 23 minutes) :  0, 83
Time to review(5 hours 50 minutes) :  0, 350
Time to approve(6 hours 6 minutes) :  0, 366
Time to merge(14 hours 14 minutes) :  0, 854
Loading

longest-pending reviews

  1. IS-87.00 Database Schema(68 hours 24 minutes)
  2. PSP-8710 batch uploads(66 hours 54 minutes)
  3. IS-86.00 Database Schema(43 hours 50 minutes)
  4. psp-9007 ensure automatic gst amount calculations work properly.(20 hours 56 minutes)
  5. psp-7788 | Crown Layers on popup(20 hours 8 minutes)

longest-pending approvals

  1. PSP-7158 Allow moving the position of map markers (within the file) (122 hours 29 minutes)
  2. Release 5.4(54 hours 13 minutes)
  3. PSP-8880: Add Payee tab to Payable leases(32 minutes)
  4. PSP-8710 batch uploads(8 minutes)
  5. Bump DEV version to IS87(-)

longest-pending merge

  1. Psp 8960 - add appropriate type of auth based on what is required for layer.(30 hours 7 minutes)
  2. Update frontend to handle desynchronized models.(29 hours 13 minutes)
  3. PSP-8880: Add Payee tab to Payable leases(16 hours 16 minutes)
  4. psp-7878 | Improvements to zoom handling(16 hours 5 minutes)
  5. Lease/License Type and Lease Purpose Seed Script Fixes(15 hours 40 minutes)

Contribution stats 8/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 6 6 +4488/-935 3/1/0/0/2 12 10
devinleighsmith 11 9 +311182/-40784 6/1/2/0/2 0 6
eddherrera 3 3 +50/-58 2/1/0/0/0 0 6
FuriousLlama 6 5 +5938/-1755 0/2/0/1/3 7 11
stairaku 2 2 +2998/-1681 0/0/0/0/2 3 0

Pull request quality 8/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 6 0 3 / 0 / 7 8
devinleighsmith 9 1 0 / 0 / 0 0
eddherrera 3 0 0 / 0 / 0 0
FuriousLlama 5 0 0 / 0 / 4 4
stairaku 2 0 0 / 0 / 3 3

The most commented PRs

  1. PSP-7158 Allow moving the position of map markers (within the file) (8)
  2. psp-7878 | Improvements to zoom handling(6)
  3. PSP-8710 batch uploads(4)
  4. PSP-8880: Add Payee tab to Payable leases(3)
  5. Scaffold/s86(1)

Code review engagement 8/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 6 0 / 0 / 1 1 3/2/1/2/2 0 / 1 / 10
devinleighsmith 9 0 / 0 / 6 6 2/2/0/0/2 0 / 2 / 6
eddherrera 3 2 / 0 / 3 3 1/0/0/0/5 0 / 1 / 6
FuriousLlama 5 1 / 0 / 4 5 4/1/0/1/5 1 / 1 / 11
stairaku 2 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 8/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response
asanchezr 1 10 3 hours 59 minutes
devinleighsmith 0 6 2 hours 2 minutes
eddherrera 2 6 16 hours 38 minutes 2 minutes
FuriousLlama 2 11 24 hours 41 minutes

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 7/2024

References

Pull requests timeline(75th percentile) 7/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review Time to approve Time to merge Total merged PRs
asanchezr 16 hours 42 minutes 16 hours 42 minutes 18 hours 19 minutes 11
devinleighsmith 19 hours 18 minutes 19 hours 18 minutes 22 hours 50 minutes 32
eddherrera 1 hour 49 minutes 5 hours 50 minutes 18 hours 24 minutes 15
FuriousLlama 12 hours 48 minutes 16 hours 44 minutes 17 hours 12 minutes 11
stairaku 2 hours 9 minutes 2 hours 9 minutes 3 hours 38 minutes 9 
gantt
title Pull requests timeline(75th percentile) 7/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review(16 hours 42 minutes) :  0, 1002
Time to approve(16 hours 42 minutes) :  0, 1002
Time to merge(18 hours 19 minutes) :  0, 1099
        
section devinleighsmith
                Time to review(19 hours 18 minutes) :  0, 1158
Time to approve(19 hours 18 minutes) :  0, 1158
Time to merge(22 hours 50 minutes) :  0, 1370
        
section eddherrera
                Time to review(1 hour 49 minutes) :  0, 109
Time to approve(5 hours 50 minutes) :  0, 350
Time to merge(18 hours 24 minutes) :  0, 1104
        
section FuriousLlama
                Time to review(12 hours 48 minutes) :  0, 768
Time to approve(16 hours 44 minutes) :  0, 1004
Time to merge(17 hours 12 minutes) :  0, 1032
        
section stairaku
                Time to review(2 hours 9 minutes) :  0, 129
Time to approve(2 hours 9 minutes) :  0, 129
Time to merge(3 hours 38 minutes) :  0, 218
Loading

longest-pending reviews

  1. psp-8783 ensure that form state is maintained during collapsing of sidebar.(118 hours 52 minutes)
  2. psp-8365 lease flexible duration(81 hours 1 minute)
  3. psp-8708 fix tenant primary contacts.(67 hours 25 minutes)
  4. PSP-7158 Show markers positioned corresponding to that file (65 hours 44 minutes)
  5. PSP-8414 : Select one or multiple properties for H120 Generation(65 hours 2 minutes)

longest-pending approvals

  1. PSP-8414 : Select one or multiple properties for H120 Generation(26 hours 1 minute)
  2. psp-8630 | Updated Leases and added renewals(18 hours 46 minutes)
  3. PSP-8896 : FT:AcquisitionFile:Requisition: System generates warning m…(16 hours 55 minutes)
  4. PSP-8317: Lease and Licence Edit/View Fee Denomination forms(4 hours 18 minutes)
  5. PSP-7980 : Display L/L Status in Property Information Pane - Management (Summary Section)(2 hours 45 minutes)

longest-pending merge

  1. psp-8018: display retired warning immediately upon add.(122 hours 48 minutes)
  2. PSP-8708: Organization Tenants with person contacts are not displayed when tenant is selected. Small change on Contacts List View(75 hours 46 minutes)
  3. PSP-7158 Show markers positioned corresponding to that file (51 hours 4 minutes)
  4. psp-8772 lease payment export corrections.(40 hours 52 minutes)
  5. psp-8545 Correct behaviour when there is no property ownership specif…(21 hours 12 minutes)

Contribution stats 7/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 11 11 +317326/-51499 4/2/2/0/3 6 40
devinleighsmith 35 32 +12692/-4061 21/7/2/0/5 15 31
eddherrera 15 15 +4078/-2438 7/2/3/1/2 14 17
FuriousLlama 11 11 +3567/-1426 4/2/0/3/2 41 13
stairaku 11 9 +1771/-586 6/3/0/1/1 12 0

Pull request quality 7/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 11 0 0 / 0 / 3 3
devinleighsmith 32 0 0 / 0 / 8 11
eddherrera 15 2 0 / 0 / 8 11
FuriousLlama 11 1 4 / 0 / 24 25
stairaku 9 0 0 / 0 / 6 7

The most commented PRs

  1. psp-8630 | Updated Leases and added renewals(23)
  2. PSP-7980 : Display L/L Status in Property Information Pane - Management (Summary Section)(11)
  3. PSP-8317: Lease and Licence Edit/View Fee Denomination forms(11)
  4. PSP-7158 Show markers positioned corresponding to that file (6)
  5. Highway layer map popup enhancement | PSP-8332(5)

Code review engagement 7/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 11 3 / 0 / 11 13 21/9/3/2/5 0 / 6 / 39
devinleighsmith 32 1 / 0 / 32 36 12/5/4/2/8 3 / 7 / 31
eddherrera 15 0 / 0 / 3 3 11/3/0/1/2 0 / 3 / 17
FuriousLlama 11 0 / 0 / 3 5 5/1/4/0/3 0 / 3 / 13
stairaku 9 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 7/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 7 40 6 hours 36 minutes 1 hour 51 minutes
devinleighsmith 5 31 16 hours 53 minutes 26 hours 18 minutes 5 hours 22 minutes
eddherrera 0 17 18 hours 22 minutes
FuriousLlama 6 13 17 hours 44 minutes 1 hour 41 minutes
stairaku 1 0

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 6/2024

References

Pull requests timeline(75th percentile) 6/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review Time to approve Time to merge Total merged PRs
asanchezr 15 hours 18 minutes 15 hours 18 minutes 16 hours 23 minutes 14
devinleighsmith 19 hours 49 minutes 19 hours 49 minutes 22 hours 31 minutes 30
eddherrera 24 hours 11 minutes 52 hours 38 minutes 55 hours 27 minutes 11
stairaku 22 hours 47 minutes 46 hours 47 minutes 52 hours 17 minutes 8 
gantt
title Pull requests timeline(75th percentile) 6/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review(15 hours 18 minutes) :  0, 918
Time to approve(15 hours 18 minutes) :  0, 918
Time to merge(16 hours 23 minutes) :  0, 983
        
section devinleighsmith
                Time to review(19 hours 49 minutes) :  0, 1189
Time to approve(19 hours 49 minutes) :  0, 1189
Time to merge(22 hours 31 minutes) :  0, 1351
        
section eddherrera
                Time to review(24 hours 11 minutes) :  0, 1451
Time to approve(52 hours 38 minutes) :  0, 3158
Time to merge(55 hours 27 minutes) :  0, 3327
        
section stairaku
                Time to review(22 hours 47 minutes) :  0, 1367
Time to approve(46 hours 47 minutes) :  0, 2807
Time to merge(52 hours 17 minutes) :  0, 3137
Loading

longest-pending reviews

  1. PSP-8574 : Ability to view non-PS and non-LIS Historical Number Types…(103 hours 40 minutes)
  2. PSP-7930 : Generate Document Hyperlink located within L/L File Summar…(103 hours 38 minutes)
  3. Psp-7862 collapse map side bar(74 hours 42 minutes)
  4. psp-7983 update db job to display logs in github.(73 hours 53 minutes)
  5. Update mayan docker, and backend models to match 4.7 spec.(65 hours 49 minutes)

longest-pending approvals

  1. Psp-7862 collapse map side bar(69 hours 25 minutes)
  2. PSP-8566 : FT: Lease & Licences - Tenants: Select Tenants button gets…(65 hours 23 minutes)
  3. PSP-7930 : Generate Document Hyperlink located within L/L File Summar…(38 hours 53 minutes)
  4. PSP-7499: UI/UX Clean Up - Contact List(35 hours 8 minutes)
  5. psp-7590 - update moti highway/region layer to internal. Allow for so…(25 hours 44 minutes)

longest-pending merge

  1. Psp 8018 refactor property selector, show frontend warning when selecting isretired properties. (do not review until all 5.3 stories/bugs have been removed).(289 hours 55 minutes)
  2. IS-82.00 Database Schema(100 hours 14 minutes)
  3. Psp-8018: For all files do not include a retired property on selection(67 hours 43 minutes)
  4. IS-82.00 (45 hours 33 minutes)
  5. color palette renames(43 hours 15 minutes)

Contribution stats 6/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 14 14 +191750/-22107 5/0/3/1/5 4 27
devinleighsmith 34 30 +739345/-96594 13/7/2/0/12 19 29
eddherrera 12 11 +2538/-356 3/6/2/0/1 42 10
stairaku 11 8 +3547/-2717 5/0/0/2/4 0 0

Pull request quality 6/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 14 0 0 / 0 / 2 3
devinleighsmith 30 0 1 / 0 / 14 15
eddherrera 11 2 0 / 0 / 19 22
stairaku 8 2 0 / 0 / 0 0

The most commented PRs

  1. PSP-8315 : Add Lease and License Checklist(23)
  2. PSP-8337 : UI UX Clean Up - Verbiage - Licence(8)
  3. IS83 scaffold changes, also includes many renames from term to period.(5)
  4. PSP-8566 : FT: Lease & Licences - Tenants: Select Tenants button gets…(4)
  5. PSP-7930 : Generate Document Hyperlink located within L/L File Summar…(4)

Code review engagement 6/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 14 1 / 0 / 17 18 8/10/3/1/5 0 / 7 / 26
devinleighsmith 30 0 / 0 / 17 20 10/6/3/0/10 4 / 7 / 29
eddherrera 11 0 / 0 / 1 2 4/3/0/1/2 0 / 1 / 10
stairaku 8 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 6/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 6 27 23 hours 52 minutes 23 hours 52 minutes
devinleighsmith 8 29 19 hours 19 minutes 26 hours 45 minutes 19 hours 29 minutes
eddherrera 1 10 16 hours 42 minutes

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 5/2024

References

Pull requests timeline(75th percentile) 5/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 15 hours 8 minutes 15 hours 22 minutes 15 hours 29 minutes 18 hours 51 minutes 13
devinleighsmith 18 hours 10 minutes 20 hours 45 minutes 35 hours 32 minutes 38
eddherrera 22 hours 58 minutes 32 hours 36 minutes 33 hours 36 minutes 10
FuriousLlama 23 hours 16 minutes 35 hours 28 minutes 54 hours 19 minutes 18
stairaku 24 hours 10 minutes 24 hours 12 minutes 34 hours 28 minutes 6 
gantt
title Pull requests timeline(75th percentile) 5/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review request(15 hours 8 minutes) :  0, 908
Time to review(15 hours 22 minutes) :  0, 922
Time to approve(15 hours 29 minutes) :  0, 929
Time to merge(18 hours 51 minutes) :  0, 1131
        
section devinleighsmith
                Time to review(18 hours 10 minutes) :  0, 1090
Time to approve(20 hours 45 minutes) :  0, 1245
Time to merge(35 hours 32 minutes) :  0, 2132
        
section eddherrera
                Time to review(22 hours 58 minutes) :  0, 1378
Time to approve(32 hours 36 minutes) :  0, 1956
Time to merge(33 hours 36 minutes) :  0, 2016
        
section FuriousLlama
                Time to review(23 hours 16 minutes) :  0, 1396
Time to approve(35 hours 28 minutes) :  0, 2128
Time to merge(54 hours 19 minutes) :  0, 3259
        
section stairaku
                Time to review(24 hours 10 minutes) :  0, 1450
Time to approve(24 hours 12 minutes) :  0, 1452
Time to merge(34 hours 28 minutes) :  0, 2068
Loading

longest-pending reviews

  1. styled modal that warns the user is leaving a form.(457 hours 19 minutes)
  2. pims document preview - pre-cache.(130 hours 52 minutes)
  3. IS-80.00 Database Schema(95 hours 9 minutes)
  4. psp-8477 - use fully attributed parcel map.(77 hours 37 minutes)
  5. psp-5511 display mayan document previews.(74 hours 10 minutes)

longest-pending approvals

  1. PSP-8114 : Expose Mayan errors to frontend (temporarily)(484 hours 15 minutes)
  2. Psp 8109 - color palette refactor(198 hours 34 minutes)
  3. Psp 8099 - allow special instruction whitespace to display.(101 hours 34 minutes)
  4. PSP-8227 : Add search for "historical file number" on the property se…(51 hours 6 minutes)
  5. psp-8499 | Updated historical number rendering for leases(48 hours 26 minutes)

longest-pending merge

  1. Psp 8109 - color palette refactor(68 hours 37 minutes)
  2. psp-8353 add missing disposition message.(48 hours 53 minutes)
  3. psp-7494 | Lease depost UI enhancements(47 hours 30 minutes)
  4. psp-8185 remove closebutton generic modal prop - show custom pims clo…(43 hours 39 minutes)
  5. PSP-8361: Automation updates based on IS79 build on Test Environment(42 hours 21 minutes)

Contribution stats 5/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 13 13 +116289/-37272 4/2/0/2/5 12 32
devinleighsmith 39 38 +364408/-48668 21/7/3/1/7 60 34
eddherrera 10 10 +4552/-3941 1/2/3/1/3 31 16
FuriousLlama 19 18 +10112/-6440 3/4/3/3/6 31 14
stairaku 6 6 +1056/-1105 1/2/2/0/1 4 0

Pull request quality 5/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 13 0 0 / 0 / 7 7
devinleighsmith 38 0 0 / 0 / 28 34
eddherrera 10 2 0 / 0 / 15 16
FuriousLlama 18 4 0 / 0 / 18 20
stairaku 6 0 0 / 0 / 2 2

The most commented PRs

  1. psp-5511 display mayan document previews.(23)
  2. Psp 8109 - color palette refactor(14)
  3. psp-8228 | Updated header status display(9)
  4. PSP-8314 : Record reason for rejecting or terminating a lease(8)
  5. PSP-8225 : Adjust "historical file number" on the lease/license search to search across all Historical Numbers(8)

Code review engagement 5/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 13 0 / 0 / 12 14 14/8/3/2/5 0 / 5 / 31
devinleighsmith 38 0 / 0 / 38 40 7/6/6/4/11 6 / 18 / 33
eddherrera 10 0 / 0 / 6 6 7/4/1/1/3 0 / 2 / 16
FuriousLlama 18 0 / 0 / 14 19 4/3/1/1/5 0 / 3 / 12
stairaku 6 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 5/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 6 32 17 hours 54 minutes 11 minutes
devinleighsmith 11 34 22 hours 38 minutes 22 hours 58 minutes 22 hours 54 minutes
eddherrera 2 16 17 hours 6 minutes
FuriousLlama 9 14 18 hours 29 minutes

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 4/2024

References

Pull requests timeline(75th percentile) 4/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 15 hours 59 minutes 16 hours 3 minutes 17 hours 40 minutes 11
devinleighsmith 24 hours 34 minutes 20 hours 20 minutes 20 hours 41 minutes 62 hours 56 minutes 29
eddherrera 23 hours 48 minutes 38 hours 43 minutes 38 hours 45 minutes 54 hours 44 minutes 3
FuriousLlama 21 hours 30 minutes 24 hours 30 minutes 49 hours 18 minutes 9
stairaku 14 hours 55 minutes 14 hours 55 minutes 14 hours 57 minutes 2 
gantt
title Pull requests timeline(75th percentile) 4/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review(15 hours 59 minutes) :  0, 959
Time to approve(16 hours 3 minutes) :  0, 963
Time to merge(17 hours 40 minutes) :  0, 1060
        
section devinleighsmith
                Time to review request(24 hours 34 minutes) :  0, 1474
Time to review(20 hours 20 minutes) :  0, 1220
Time to approve(20 hours 41 minutes) :  0, 1241
Time to merge(62 hours 56 minutes) :  0, 3776
        
section eddherrera
                Time to review request(23 hours 48 minutes) :  0, 1428
Time to review(38 hours 43 minutes) :  0, 2323
Time to approve(38 hours 45 minutes) :  0, 2325
Time to merge(54 hours 44 minutes) :  0, 3284
        
section FuriousLlama
                Time to review(21 hours 30 minutes) :  0, 1290
Time to approve(24 hours 30 minutes) :  0, 1470
Time to merge(49 hours 18 minutes) :  0, 2958
        
section stairaku
                Time to review(14 hours 55 minutes) :  0, 895
Time to approve(14 hours 55 minutes) :  0, 895
Time to merge(14 hours 57 minutes) :  0, 897
Loading

longest-pending reviews

  1. psp-8158 ensure that all subdivisions/consolidations only allow for owned sour…(99 hours 3 minutes)
  2. Psp 7581 - PROPOSAL - use bootstrap for 4px spacing. fix link styling and pagination styling.(97 hours 47 minutes)
  3. psp-8166 hide toolbar on associated property operations.(97 hours 35 minutes)
  4. Psp 7883 - remove acquisition completion date.(92 hours 5 minutes)
  5. IS-79.00 Database Schema(73 hours 1 minute)

longest-pending approvals

  1. PSP-8253: Fixed looking for property in the property listview(50 hours 36 minutes)
  2. Add asnotracking, with unrelated bugfix for view documents screen.(22 hours 15 minutes)
  3. PSP-8094, PSP-8095: Warn user that property is part of an existing file(6 hours 13 minutes)
  4. Take property update and cleanup(5 hours 27 minutes)
  5. PSP-7884 add take completion date.(1 hour 5 minutes)

longest-pending merge

  1. Vitest(192 hours 9 minutes)
  2. update link styling, including tab underlines.(166 hours 51 minutes)
  3. Tech debt/vite(121 hours 50 minutes)
  4. PSP-8094, PSP-8095 Warn user that property is part of an existing acquisition/research file(68 hours 45 minutes)
  5. PSP-7884 add take completion date.(47 hours 44 minutes)

Contribution stats 4/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 12 11 +1862/-775 9/0/0/2/1 14 19
devinleighsmith 34 29 +782780/-196564 15/1/3/2/13 15 23
eddherrera 3 3 +467/-125 1/1/1/0/0 3 7
FuriousLlama 10 9 +25908/-18746 2/3/0/2/3 33 17
stairaku 2 2 +1048/-212 0/0/1/0/1 0 0

Pull request quality 4/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 11 0 0 / 0 / 5 7
devinleighsmith 29 1 0 / 0 / 6 8
eddherrera 3 0 0 / 0 / 1 1
FuriousLlama 9 1 1 / 0 / 15 18
stairaku 2 0 0 / 0 / 0 0

The most commented PRs

  1. Features/psp 7836 filter(23)
  2. Take property update and cleanup(8)
  3. Update to IS-77.00 Database Schema(8)
  4. PSP-8094, PSP-8095 Warn user that property is part of an existing acquisition/research file(6)
  5. PSP-8103 Warn user that property is part of any disposition file(5)

Code review engagement 4/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 11 0 / 0 / 0 0 10/3/3/2/1 0 / 0 / 19
devinleighsmith 29 1 / 0 / 21 28 11/3/1/3/5 1 / 7 / 21
eddherrera 3 0 / 0 / 4 4 4/0/2/1/0 1 / 1 / 7
FuriousLlama 9 0 / 0 / 4 6 7/1/1/1/7 0 / 3 / 17
stairaku 2 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 4/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response
asanchezr 2 19 20 hours 25 minutes
devinleighsmith 3 23 19 hours 54 minutes 22 hours 33 minutes
eddherrera 4 7 42 hours 32 minutes
FuriousLlama 1 17 20 hours

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 3/2024

References

Pull requests timeline(75th percentile) 3/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 19 hours 59 minutes 12 hours 49 minutes 12 hours 49 minutes 13 hours 17 minutes 15
devinleighsmith 16 hours 39 minutes 17 hours 47 minutes 24 hours 14 minutes 36
eddherrera 31 hours 19 minutes 33 hours 35 minutes 74 hours 1 minute 74 hours 48 minutes 14
FuriousLlama 40 hours 37 minutes 41 hours 38 minutes 45 hours 2 minutes 10
stairaku 9 hours 30 minutes 9 hours 30 minutes 28 hours 55 minutes 3 
gantt
title Pull requests timeline(75th percentile) 3/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review request(19 hours 59 minutes) :  0, 1199
Time to review(12 hours 49 minutes) :  0, 769
Time to approve(12 hours 49 minutes) :  0, 769
Time to merge(13 hours 17 minutes) :  0, 797
        
section devinleighsmith
                Time to review(16 hours 39 minutes) :  0, 999
Time to approve(17 hours 47 minutes) :  0, 1067
Time to merge(24 hours 14 minutes) :  0, 1454
        
section eddherrera
                Time to review request(31 hours 19 minutes) :  0, 1879
Time to review(33 hours 35 minutes) :  0, 2015
Time to approve(74 hours 1 minute) :  0, 4441
Time to merge(74 hours 48 minutes) :  0, 4488
        
section FuriousLlama
                Time to review(40 hours 37 minutes) :  0, 2437
Time to approve(41 hours 38 minutes) :  0, 2498
Time to merge(45 hours 2 minutes) :  0, 2702
        
section stairaku
                Time to review(9 hours 30 minutes) :  0, 570
Time to approve(9 hours 30 minutes) :  0, 570
Time to merge(28 hours 55 minutes) :  0, 1735
Loading

longest-pending reviews

  1. psp-7986 update ts version - increment packages with vulnerabilities.(315 hours 32 minutes)
  2. psp-7658 display is retired in property list view.(97 hours 46 minutes)
  3. psp-7622 Testing(93 hours 23 minutes)
  4. IS-75.00 Database Schema Changes(69 hours 20 minutes)
  5. Psp 8009 - login page changes.(47 hours 7 minutes)

longest-pending approvals

  1. SPIKE: Vite (619 hours 32 minutes)
  2. PSP-7681 : FT-REG: Browser alerts should be replaced by established modal dialogs(317 hours 15 minutes)
  3. PSP-8004 : FT:UI/UX- Agreements: tooltip icon for Deposit due no late…(100 hours 54 minutes)
  4. PSP-7500 - UI/UX cleanup agreements create /edit(65 hours 8 minutes)
  5. PSP-7869 Indicate "retired" on property information details (43 hours 21 minutes)

longest-pending merge

  1. psp-5703: add unit tests for document sync and repository(3884 hours 34 minutes)
  2. update docker-compose so primary docker compose refers to mayan.(98 hours 59 minutes)
  3. PSP-8023 user management/access request tooltip updates.(53 hours 46 minutes)
  4. psp-7993 correct recursive model object.(40 hours 27 minutes)
  5. PSP-7876 : Prevent editing on retired property details(26 hours 25 minutes)

Contribution stats 3/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 15 15 +90876/-11197 7/2/2/2/2 15 32
devinleighsmith 37 36 +435411/-60325 24/4/3/1/5 25 22
eddherrera 16 14 +282778/-66516 5/7/2/0/2 67 13
FuriousLlama 11 10 +3340/-778 4/3/1/2/1 19 30
stairaku 3 3 +2069/-724 0/0/0/1/2 0 0

Pull request quality 3/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 15 0 1 / 0 / 9 9
devinleighsmith 36 0 0 / 0 / 9 12
eddherrera 14 0 0 / 0 / 28 37
FuriousLlama 10 1 0 / 0 / 11 11
stairaku 3 0 0 / 0 / 0 0

The most commented PRs

  1. PSP-7500 - UI/UX cleanup agreements create /edit(42)
  2. PSP-7869 Indicate "retired" on property information details (9)
  3. PSP-7929 : Backend error - For all files do not include a retired property on selection(8)
  4. psp 7385 | Consolidation frontend(7)
  5. Test corrections - correct all console warnings/errors(7)

Code review engagement 3/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 15 0 / 0 / 9 13 18/5/3/1/5 0 / 8 / 30
devinleighsmith 36 0 / 0 / 7 9 9/5/2/4/2 1 / 5 / 22
eddherrera 14 0 / 0 / 11 11 10/1/1/0/1 0 / 3 / 13
FuriousLlama 10 1 / 0 / 30 36 15/3/5/1/6 0 / 9 / 26
stairaku 3 0 / 0 / 0 0 0/0/0/0/0 0 / 0 / 0

Review Request Response Time(75th percentile) 3/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 7 32 14 hours 56 minutes 12 hours 33 minutes
devinleighsmith 9 22 16 hours 26 minutes 63 hours 41 minutes 51 hours 32 minutes
eddherrera 2 13 16 hours 10 minutes
FuriousLlama 8 30 30 hours 56 minutes 15 hours 22 minutes
stairaku 1 0

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 2/2024

References

Pull requests timeline(75th percentile) 2/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 99 hours 15 minutes 19 hours 43 minutes 19 hours 43 minutes 19 hours 54 minutes 16
devinleighsmith 413 hours 47 minutes 40 hours 44 minutes 40 hours 44 minutes 47 hours 34 minutes 29
eddherrera 9 hours 38 minutes 23 hours 18 minutes 58 hours 53 minutes 2
FuriousLlama 2 hours 7 minutes 2 hours 15 minutes 5 hours 23 minutes 17
stairaku 1 hour 15 minutes 1 hour 15 minutes 2 hours 18 minutes 4 
gantt
title Pull requests timeline(75th percentile) 2/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review request(99 hours 15 minutes) :  0, 5955
Time to review(19 hours 43 minutes) :  0, 1183
Time to approve(19 hours 43 minutes) :  0, 1183
Time to merge(19 hours 54 minutes) :  0, 1194
        
section devinleighsmith
                Time to review request(413 hours 47 minutes) :  0, 24827
Time to review(40 hours 44 minutes) :  0, 2444
Time to approve(40 hours 44 minutes) :  0, 2444
Time to merge(47 hours 34 minutes) :  0, 2854
        
section eddherrera
                Time to review(9 hours 38 minutes) :  0, 578
Time to approve(23 hours 18 minutes) :  0, 1398
Time to merge(58 hours 53 minutes) :  0, 3533
        
section FuriousLlama
                Time to review(2 hours 7 minutes) :  0, 127
Time to approve(2 hours 15 minutes) :  0, 135
Time to merge(5 hours 23 minutes) :  0, 323
        
section stairaku
                Time to review(1 hour 15 minutes) :  0, 75
Time to approve(1 hour 15 minutes) :  0, 75
Time to merge(2 hours 18 minutes) :  0, 138
Loading

longest-pending reviews

  1. Dead code/lint update - read description(521 hours 28 minutes)
  2. SPIKE: Siteminder Refresh(465 hours 21 minutes)
  3. psp-7323 Contact ambiguous(263 hours 26 minutes)
  4. psp-7548 ensure last update/date time reflects diposition file sub-entities correctly.(238 hours)
  5. PSP-7547 Auto-select region for disposition file(210 hours 31 minutes)

longest-pending approvals

  1. psp-7275 complete a disposition file. psp-7785, psp-7322, psp-7568(259 hours 4 minutes)
  2. Dead code/lint update - read description(120 hours 11 minutes)
  3. Tech debt - Remove old and duplicated models(76 hours 47 minutes)
  4. PSP-7618 : Re-add project/product to Disposition Files (Create, Update and View File Summary)(27 hours 20 minutes)
  5. psp-7607 correct creating file from orange marker not working properly.(11 hours 14 minutes)

longest-pending merge

  1. psp-7323 Contact ambiguous(174 hours 1 minute)
  2. Fix local development issues.(70 hours 25 minutes)
  3. psp-7880 disposition file number export display.(43 hours 31 minutes)
  4. Release 5.0 hotfix 1(37 hours 34 minutes)
  5. psp-7679 display lease province and country(29 hours 32 minutes)

Contribution stats 2/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 17 16 +448357/-88853 6/3/3/0/5 0 15
devinleighsmith 32 29 +12556/-28750 20/3/2/3/4 39 19
eddherrera 2 2 +1060/-211 1/0/0/0/1 19 17
FuriousLlama 18 17 +184750/-51322 8/1/3/1/5 37 24
stairaku 4 4 +2150/-1576 0/0/0/3/1 0 1

Pull request quality 2/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 16 0 0 / 0 / 0 0
devinleighsmith 29 1 0 / 0 / 24 29
eddherrera 2 0 0 / 0 / 9 11
FuriousLlama 17 0 0 / 0 / 21 23
stairaku 4 0 0 / 0 / 0 0

The most commented PRs

  1. PSP-7618 : Re-add project/product to Disposition Files (Create, Update and View File Summary)(18)
  2. Tech debt - Remove old and duplicated models(13)
  3. psp-7598 | Properties list view filter by ownership(13)
  4. psp-7275 complete a disposition file. psp-7785, psp-7322, psp-7568(10)
  5. PSP-7622 | Added Subdivision view and backend retrieval of property operations(9)

Code review engagement 2/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 16 0 / 0 / 15 16 6/1/0/4/4 0 / 3 / 14
devinleighsmith 29 0 / 0 / 22 26 7/0/4/2/6 0 / 4 / 18
eddherrera 2 0 / 0 / 3 5 14/1/1/0/1 0 / 3 / 17
FuriousLlama 17 0 / 0 / 14 16 10/5/1/2/6 1 / 8 / 21
stairaku 4 0 / 0 / 0 0 0/0/1/0/0 0 / 0 / 1

Review Request Response Time(75th percentile) 2/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 1 15 2 hours 20 minutes
devinleighsmith 3 19 17 hours 22 minutes 13 hours 7 minutes 11 hours 48 minutes
eddherrera 2 17 37 hours 4 minutes
FuriousLlama 3 24 42 hours 9 minutes 83 hours 49 minutes
stairaku 1 1

@devinleighsmith
Copy link
Collaborator Author

Pull Request report 1/2024

References

Pull requests timeline(75th percentile) 1/2024

Time to review - time from PR creation to first review.
Time to approve - time from PR creation to first approval without requested changes.
Time to merge - time from PR creation to merge.

user Time in draft Time to review request Time to review Time to approve Time to merge Total merged PRs
asanchezr 17 hours 24 minutes 17 hours 24 minutes 19 hours 43 minutes 8
devinleighsmith 17 hours 4 minutes 43 hours 38 minutes 43 hours 38 minutes 68 hours 35 minutes 30
eddherrera 25 hours 58 minutes 74 hours 49 minutes 89 hours 25 minutes 8
FuriousLlama 325 hours 19 minutes 10 hours 35 minutes 114 hours 52 minutes 144 hours 18 minutes 4
stairaku 15 hours 54 minutes 15 hours 54 minutes 38 hours 48 minutes 4 
gantt
title Pull requests timeline(75th percentile) 1/2024 / minutes
dateFormat X
axisFormat %s
section asanchezr
                Time to review(17 hours 24 minutes) :  0, 1044
Time to approve(17 hours 24 minutes) :  0, 1044
Time to merge(19 hours 43 minutes) :  0, 1183
        
section devinleighsmith
                Time to review request(17 hours 4 minutes) :  0, 1024
Time to review(43 hours 38 minutes) :  0, 2618
Time to approve(43 hours 38 minutes) :  0, 2618
Time to merge(68 hours 35 minutes) :  0, 4115
        
section eddherrera
                Time to review(25 hours 58 minutes) :  0, 1558
Time to approve(74 hours 49 minutes) :  0, 4489
Time to merge(89 hours 25 minutes) :  0, 5365
        
section FuriousLlama
                Time in draft(325 hours 19 minutes) :  0, 19519
Time to review(10 hours 35 minutes) :  0, 635
Time to approve(114 hours 52 minutes) :  0, 6892
Time to merge(144 hours 18 minutes) :  0, 8658
        
section stairaku
                Time to review(15 hours 54 minutes) :  0, 954
Time to approve(15 hours 54 minutes) :  0, 954
Time to merge(38 hours 48 minutes) :  0, 2328
Loading

longest-pending reviews

  1. Psp 7306 - update term modal ui(258 hours 11 minutes)
  2. PSP-7427: Automation Refactoring(185 hours 59 minutes)
  3. disposition merge to dev, dotnet 8 update, ef update.(165 hours 58 minutes)
  4. IS-72.00 Database Schema(119 hours 4 minutes)
  5. psp-7580 correct disposition list view file number.(92 hours 19 minutes)

longest-pending approvals

  1. Techdebt/use generated document models(461 hours 36 minutes)
  2. Tech debt| use new api files and null enhancements(96 hours 18 minutes)
  3. PSP-7296 : Create/Edit Sales Details (Disposition)(75 hours 39 minutes)
  4. PSP-7509 : Allow Contractor to Create or Edit Disposition File(74 hours 41 minutes)
  5. PSP-7295 : Create/Edit Appraisal and Assessment(5 hours 31 minutes)

longest-pending merge

  1. Contact Ambiguous(530 hours 15 minutes)
  2. psp-7630 ensure that properties added directly to inventory have the …(45 hours 40 minutes)
  3. psp-7609 ensure that changing the status of a disposition file generates a note(45 hours 8 minutes)
  4. Psp 7611 - ensure undefined/null handled correctly by contact parsers.(42 hours 43 minutes)
  5. Tech debt| use new api files and null enhancements(29 hours 26 minutes)

Contribution stats 1/2024

Reviews conducted - number of reviews conducted. 1 PR may have only single review.
PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl

user Total opened PRs Total merged PRs Additions/Deletions PR size: xs/s/m/l/xl Total comments Reviews conducted
asanchezr 10 8 +42269/-19471 5/2/1/0/2 1 19
devinleighsmith 31 30 +887564/-120762 17/4/1/0/9 11 22
eddherrera 12 8 +16825/-2048 0/2/1/1/8 95 18
FuriousLlama 5 4 +14968/-10299 1/1/1/0/2 60 6
stairaku 4 4 +2561/-1205 1/0/1/1/1 0 2

Pull request quality 1/2024

Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Changes requested received Agreed / Disagreed / Total discussions received Comments received
asanchezr 8 0 0 / 0 / 1 1
devinleighsmith 30 0 0 / 0 / 11 11
eddherrera 8 1 0 / 0 / 43 54
FuriousLlama 4 1 1 / 0 / 37 39
stairaku 4 0 0 / 0 / 0 0

The most commented PRs

  1. PSP-7296 : Create/Edit Sales Details (Disposition)(64)
  2. Tech debt| use new api files and null enhancements(41)
  3. Techdebt/use generated document models(19)
  4. PSP-7509 : Allow Contractor to Create or Edit Disposition File(15)
  5. PSP-7271 : Create/Edit Offer (Disposition)(9)

Code review engagement 1/2024

PR Size - determined using the formula: additions + deletions * 0.5. Based on this calculation: 0-50: xs, 51-200: s, 201-400: m, 401-700: l, 701+: xl
Changes requested / Comments / Approvals - number of reviews conducted by user. For a single pull request, only one review of each status will be counted for a user.
Agreed - discussions with at least 1 reaction 👍.
Disagreed - discussions with at least 1 reaction 👎.

user Total merged PRs Agreed / Disagreed / Total discussions conducted Comments conducted PR size: xs/s/m/l/xl Changes requested / Commented / Approved
asanchezr 8 0 / 0 / 13 13 7/5/1/1/5 0 / 4 / 18
devinleighsmith 30 1 / 0 / 62 71 5/4/2/2/9 2 / 7 / 22
eddherrera 8 0 / 0 / 1 1 12/0/1/0/5 0 / 1 / 18
FuriousLlama 4 0 / 0 / 16 20 2/1/1/0/2 1 / 2 / 6
stairaku 4 0 / 0 / 0 0 0/0/1/1/0 0 / 0 / 2

Review Request Response Time(75th percentile) 1/2024

Time from re-request to response - time from a review re-request to the response. Multiple re-requests and responses can occur in a single pull request

user Review requests conducted Reviews conducted Time from opening to response Time from initial request to response Time from re-request to response
asanchezr 8 19 11 hours 54 minutes
devinleighsmith 13 22 27 hours 41 minutes 25 hours 58 minutes 20 hours 40 minutes
eddherrera 5 18 46 hours 44 minutes 17 minutes
FuriousLlama 3 6 63 hours 39 minutes 11 hours 33 minutes
stairaku 2 2 10 hours 14 minutes 10 hours 12 minutes

@devinleighsmith devinleighsmith changed the title Pull requests report(19/08/2024 21:01) Pull requests report(19/08/2024 21:02) Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devinleighsmith