Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS-55.00 Regenerated Schema #3209

Merged
merged 9 commits into from
May 31, 2023
Merged

IS-55.00 Regenerated Schema #3209

merged 9 commits into from
May 31, 2023

Conversation

dfilteau
Copy link
Contributor

Regenerated to address spurious errors.

PSP_PIMS S55.00 Sprint 55 2023-May-26

  • Added tables:
  • PIMS_ACQUISITION_OWNER_REP
  • PIMS_ACQUISITION_OWNER_REP_HIST
  • PIMS_INTEREST_HOLDER
  • PIMS_INTEREST_HOLDER_HIST
  • PIMS_INTEREST_HOLDER_INTEREST_TYPE
  • PIMS_INTHLDR_PROP_INTEREST
  • PIMS_INTHLDR_PROP_INTEREST_HIST
  • Altered tables:
  • PIMS_ACQ_CHKLST_ITEM_TYPE
  • PIMS_ACQ_CHKLST_SECTION_TYPE
  • PIMS_ACQ_PAYEE_CHEQUE
  • PIMS_ACQ_PAYEE_CHEQUE_HIST
  • PIMS_ACQUISITION_PAYEE
  • PIMS_ACQUISITION_PAYEE_HIST
  • Added seed scripts:
  • 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql
  • Altered seed scripts:
  • 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql
  • 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql
  • Requires additional metadata to meet standards

dfilteau and others added 8 commits May 26, 2023 15:47
@dfilteau
IS-55.00 Database Schema
ad7b52e 
PSP_PIMS S55.00 Sprint 55 2023-May-26
- Added tables:
  - PIMS_ACQUISITION_OWNER_REP
  - PIMS_ACQUISITION_OWNER_REP_HIST
  - PIMS_INTEREST_HOLDER
  - PIMS_INTEREST_HOLDER_HIST
  - PIMS_INTEREST_HOLDER_INTEREST_TYPE
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_INTHLDR_PROP_INTEREST_HIST
- Altered tables:
  - PIMS_ACQ_CHKLST_ITEM_TYPE
  - PIMS_ACQ_CHKLST_SECTION_TYPE
  - PIMS_ACQ_PAYEE_CHEQUE
  - PIMS_ACQ_PAYEE_CHEQUE_HIST
  - PIMS_ACQUISITION_PAYEE
  - PIMS_ACQUISITION_PAYEE_HIST
- Added seed scripts:
  - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql
- Altered seed scripts:
  - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql
  - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql
- Requires additional metadata to meet standards
@dfilteau
Added Spatial Indicies
4584411 
Added the conditional creation of spatial indices in PIMS_PROPERTY
- 005_PSP_PIMS_PROPERTY_SPATIAL_IDX.sql
@dfilteau
Added Deletion of Dynamic Constraints to Alter Up
3164430 
003_Delete_DynamicConstraint.sql
@dfilteau
Added Foreign Key
aba4769 
Added foreign key between Acquisition File and Interest Holder
@dfilteau
Dropped FK Script in Alter Down
87e6fd3
@dfilteau
Merge branch 'bcgov:dev' into IS-55.00
44f6927
@dfilteau
Added Payment in Trust
e46cbe9 
Added IS_PAYMENT_IN_TRUST to PIMS_ACQ_PAYEE_CHEQUE
@dfilteau
IS-55.00 Regenerated Schema
eae4a6f 
Regenerated to address spurious errors.

PSP_PIMS S55.00 Sprint 55 2023-May-26
- Added tables:
  - PIMS_ACQUISITION_OWNER_REP
  - PIMS_ACQUISITION_OWNER_REP_HIST
  - PIMS_INTEREST_HOLDER
  - PIMS_INTEREST_HOLDER_HIST
  - PIMS_INTEREST_HOLDER_INTEREST_TYPE
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_INTHLDR_PROP_INTEREST_HIST
- Altered tables:
  - PIMS_ACQ_CHKLST_ITEM_TYPE
  - PIMS_ACQ_CHKLST_SECTION_TYPE
  - PIMS_ACQ_PAYEE_CHEQUE
  - PIMS_ACQ_PAYEE_CHEQUE_HIST
  - PIMS_ACQUISITION_PAYEE
  - PIMS_ACQUISITION_PAYEE_HIST
- Added seed scripts:
  - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql
- Altered seed scripts:
  - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql
  - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql
- Requires additional metadata to meet standards
@FuriousLlama FuriousLlama self-assigned this May 31, 2023
@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

devinleighsmith
devinleighsmith requested changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfilteau this does not fix the problems with the IS55 alter up/build.

ie: this is still present:
[PIMS_INTHLDR_PROP_INTEREST_ID] varchar(40) NOT NULL CONSTRAINT [IHPRIN_PIMS_INTHLDR_PROP_INTEREST_ID_DEF] DEFAULT ('NEXT VALUE FOR [PIMS_INTHLDR_PROP_INTEREST_ID_SEQ]'),

FuriousLlama
FuriousLlama reviewed May 31, 2023
View reviewed changes
source/database/mssql/scripts/dbscripts/PSP_PIMS_LATEST/Alter Up/002_PSP_PIMS_Alter_Up.sql
Comment on lines 67 to 68
PRINT N'Create sequence dbo.PIMS_INTHLDR_PROP_INTEREST_ID_SEQ'
GO
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is with the table definition:

CREATE TABLE [dbo].[PIMS_INTHLDR_PROP_INTEREST]  ( 
	[PIMS_INTHLDR_PROP_INTEREST_ID]     	varchar(40) NOT NULL CONSTRAINT [IHPRIN_PIMS_INTHLDR_PROP_INTEREST_ID_DEF]  DEFAULT ('NEXT VALUE FOR [PIMS_INTHLDR_PROP_INTEREST_ID_SEQ]'),
	```

@dfilteau
Fixed PIMS_INTHLDR_PROP_INTEREST
b35e9f0 
VARCHAR(40) changed to BIGINT
@dfilteau
Copy link
Contributor Author

@dfilteau this does not fix the problems with the IS55 alter up/build.

ie: this is still present: [PIMS_INTHLDR_PROP_INTEREST_ID] varchar(40) NOT NULL CONSTRAINT [IHPRIN_PIMS_INTHLDR_PROP_INTEREST_ID_DEF] DEFAULT ('NEXT VALUE FOR [PIMS_INTHLDR_PROP_INTEREST_ID_SEQ]'),

@devinleighsmith, @FuriousLlama, fixed now.

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@FuriousLlama FuriousLlama merged commit fe2b897 into bcgov:dev May 31, 2023
devinleighsmith pushed a commit to devinleighsmith/PSP that referenced this pull request Jun 1, 2023
@dfilteau
IS-55.00 Regenerated Schema (bcgov#3209)
177b390 
* IS-55.00 Database Schema

PSP_PIMS S55.00 Sprint 55 2023-May-26
- Added tables:
  - PIMS_ACQUISITION_OWNER_REP
  - PIMS_ACQUISITION_OWNER_REP_HIST
  - PIMS_INTEREST_HOLDER
  - PIMS_INTEREST_HOLDER_HIST
  - PIMS_INTEREST_HOLDER_INTEREST_TYPE
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_INTHLDR_PROP_INTEREST_HIST
- Altered tables:
  - PIMS_ACQ_CHKLST_ITEM_TYPE
  - PIMS_ACQ_CHKLST_SECTION_TYPE
  - PIMS_ACQ_PAYEE_CHEQUE
  - PIMS_ACQ_PAYEE_CHEQUE_HIST
  - PIMS_ACQUISITION_PAYEE
  - PIMS_ACQUISITION_PAYEE_HIST
- Added seed scripts:
  - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql
- Altered seed scripts:
  - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql
  - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql
- Requires additional metadata to meet standards

* Added Spatial Indicies

Added the conditional creation of spatial indices in PIMS_PROPERTY
- 005_PSP_PIMS_PROPERTY_SPATIAL_IDX.sql

* Added Deletion of Dynamic Constraints to Alter Up

003_Delete_DynamicConstraint.sql

* Added Foreign Key

Added foreign key between Acquisition File and Interest Holder

* Dropped FK Script in Alter Down

* Added Payment in Trust

Added IS_PAYMENT_IN_TRUST to PIMS_ACQ_PAYEE_CHEQUE

* IS-55.00 Regenerated Schema

Regenerated to address spurious errors.

PSP_PIMS S55.00 Sprint 55 2023-May-26
- Added tables:
  - PIMS_ACQUISITION_OWNER_REP
  - PIMS_ACQUISITION_OWNER_REP_HIST
  - PIMS_INTEREST_HOLDER
  - PIMS_INTEREST_HOLDER_HIST
  - PIMS_INTEREST_HOLDER_INTEREST_TYPE
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_INTHLDR_PROP_INTEREST_HIST
- Altered tables:
  - PIMS_ACQ_CHKLST_ITEM_TYPE
  - PIMS_ACQ_CHKLST_SECTION_TYPE
  - PIMS_ACQ_PAYEE_CHEQUE
  - PIMS_ACQ_PAYEE_CHEQUE_HIST
  - PIMS_ACQUISITION_PAYEE
  - PIMS_ACQUISITION_PAYEE_HIST
- Added seed scripts:
  - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql
- Altered seed scripts:
  - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql
  - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql
- Requires additional metadata to meet standards

* Fixed PIMS_INTHLDR_PROP_INTEREST

VARCHAR(40) changed to BIGINT
@dfilteau dfilteau deleted the IS-55.00 branch June 1, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuriousLlama FuriousLlama FuriousLlama approved these changes

@devinleighsmith devinleighsmith devinleighsmith approved these changes

@asanchezr asanchezr Awaiting requested review from asanchezr

@stairaku stairaku Awaiting requested review from stairaku

@PryancaJSharma PryancaJSharma Awaiting requested review from PryancaJSharma

@eddherrera eddherrera Awaiting requested review from eddherrera

@buddy326 buddy326 Awaiting requested review from buddy326

Assignees

@FuriousLlama FuriousLlama

Labels
db-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfilteau @FuriousLlama @devinleighsmith