Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-6017 Ability to read "Electoral District" and "Highway District" from layers for Generated H120 #3220

Merged

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #3220 (cc93100) into dev (f67cee1) will increase coverage by 3.07%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3220      +/-   ##
==========================================
+ Coverage   73.44%   76.52%   +3.07%     
==========================================
  Files        1261      802     -459     
  Lines       28410    15067   -13343     
  Branches     5083     4117     -966     
==========================================
- Hits        20867    11530    -9337     
+ Misses       7309     3537    -3772     
+ Partials      234        0     -234     
Flag Coverage Δ
unittests 76.52% <47.61%> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/frontend/src/utils/mapPropertyUtils.ts 88.88% <20.00%> (-5.94%) ⬇️
...ition/common/GenerateForm/hooks/useGenerateH120.ts 72.97% <41.66%> (-15.03%) ⬇️
...e/frontend/src/models/generate/GenerateProperty.ts 92.30% <100.00%> (+2.30%) ⬆️

... and 460 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit a625bf4 into bcgov:dev Jun 5, 2023
@asanchezr asanchezr deleted the psp-6017-h120-electoral-district branch June 5, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants