PSP-7271 : Create/Edit Offer (Disposition) #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eddherrera
commented
Dec 28, 2023
eddherrera
commented
added 3 commits
December 29, 2023 09:45
|
(Grammar) |
|
|
||
| public PimsDispositionOffer AddDispositionFileOffer(long dispositionFileId, PimsDispositionOffer dispositionOffer) | ||
| { | ||
| _logger.LogInformation("Getting disposition file offers with DispositionFileId: {id}", dispositionFileId); |
There was a problem hiding this comment.
nit: log message is not correct.
| @@ -8,7 +8,7 @@ public class DispositionFileOfferModel : BaseConcurrentModel | |||
| /// <summary> | |||
| /// get/set - The relationship id. | |||
| /// </summary> | |||
| public long Id { get; set; } | |||
There was a problem hiding this comment.
is this actually nullable?
There was a problem hiding this comment.
For new offers the value comes as null.
| @@ -53,16 +55,31 @@ export const DispositionRouter: React.FC<IDispositionRouterProps> = props => { | |||
| </Route> | |||
| <AppRoute | |||
| exact | |||
| path={`${stripTrailingSlash(path)}/${FileTabType.OFFERS_AND_SALE}/addOffer`} | |||
| path={`${stripTrailingSlash(path)}/${FileTabType.OFFERS_AND_SALE}/offers/new`} | |||
There was a problem hiding this comment.
yes, this is better.
| const { setModalContent, setDisplayModal } = useModalContext(); | ||
| const [offerStatusError, setOfferStatusError] = useState(false); | ||
|
|
||
| const backUrl = location.pathname.split('/offers/new')[0]; |
There was a problem hiding this comment.
I'm not sure I love this pattern. Is this what we are doing in acquisition?
There was a problem hiding this comment.
It was used for Form8
| return postDispositionOffer(dispositionFileId, newOffer); | ||
| }; | ||
|
|
||
| const handleSucces = async () => { |
devinleighsmith
approved these changes
Jan 2, 2024
added 2 commits
January 2, 2024 09:13
# Conflicts: # source/backend/api/Services/DispositionFileService.cs # source/backend/tests/unit/api/Services/DispositionFileServiceTest.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.