Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-7607 correct creating file from orange marker not working properly. #3787

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the bug Something isn't working label Feb 13, 2024
@devinleighsmith devinleighsmith self-assigned this Feb 13, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith changed the title psp-7606 correct creating file from orange marker not working properly. psp-7607 correct creating file from orange marker not working properly. Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d0a526) 75.58% compared to head (6810267) 74.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3787      +/-   ##
==========================================
- Coverage   75.58%   74.02%   -1.57%     
==========================================
  Files        1449      956     -493     
  Lines       38405    20997   -17408     
  Branches     7280     6120    -1160     
==========================================
- Hits        29030    15543   -13487     
+ Misses       9081     5454    -3627     
+ Partials      294        0     -294     
Flag Coverage Δ
unittests 74.02% <100.00%> (-1.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/frontend/src/utils/mapPropertyUtils.ts 94.89% <100.00%> (+9.99%) ⬆️

... and 493 files with indirect coverage changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need geoserver config changes or did your local env leaked?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove, something weird going on with my geoserver container

@@ -70,3 +70,78 @@ export const mockFAParcelLayerResponse = {
},
bbox: [-132.1709, 48.3528, -114.6927, 56.8488],
};

export const mockFAParcelLayerResponseMultiPolygon = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets strongly type mocks so we can guarantee that it matches what is coming from the pipe, assuming you used a real sample and the internal checks can live past modifications to the model

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 6998257 into bcgov:dev Feb 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants