Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0 hotfix 1 #3805

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Release 5.0 hotfix 1 #3805

merged 5 commits into from
Feb 22, 2024

Conversation

devinleighsmith
Copy link
Collaborator

ensure property updates propagate without refresh.
Always display export as if page 1 was selected.

-force file update when properties updated to display new property information.
-ensure that user export always starts at page 1.
@devinleighsmith devinleighsmith added bug Something isn't working hotfix labels Feb 21, 2024
@devinleighsmith devinleighsmith self-assigned this Feb 21, 2024
@devinleighsmith devinleighsmith changed the base branch from dev to test February 21, 2024 02:11
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f491ca) 75.63% compared to head (c8184c9) 77.53%.
Report is 1 commits behind head on test.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             test    #3805      +/-   ##
==========================================
+ Coverage   75.63%   77.53%   +1.89%     
==========================================
  Files        1450      494     -956     
  Lines       38409    17402   -21007     
  Branches     7280     1155    -6125     
==========================================
- Hits        29050    13492   -15558     
+ Misses       9065     3616    -5449     
  Partials      294      294              
Flag Coverage Δ
unittests 77.53% <100.00%> (+1.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/backend/dal/Repositories/UserRepository.cs 78.28% <100.00%> (-0.20%) ⬇️

... and 956 files with indirect coverage changes

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 11fc7ef into bcgov:test Feb 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants