PSP-8315 : Add Lease and License Checklist #4062

eddherrera · 2024-05-30T21:01:03Z

github-actions · 2024-05-30T21:03:07Z

✅ No secrets were detected in the code.

devinleighsmith · 2024-05-31T18:38:29Z

source/backend/api/Services/LeaseService.cs

@@ -4,11 +4,14 @@
 using System.Linq;
 using System.Security.Claims;
 using System.Text;
+using DocumentFormat.OpenXml.Office2010.Excel;


probably added accidentally.

devinleighsmith · 2024-05-31T18:43:06Z

source/backend/api/Services/LeaseService.cs

@@ -88,6 +91,11 @@ public PimsLease GetById(long leaseId)
 property.Location = GeometryHelper.CreatePoint(newCoords, SpatialReference.WGS84);
 }
 }
+
+ var checkListItems = lease.PimsLeaseChecklistItems.ToList();


why is this necessary?

I couldn't pass a property as a ref to a method, I get C# warn.

oh, I meant why are we requesting/appending checklist items in the lease get method. Shouldn't that be done in a separate call to get the checklist items?
so on the frontend:

get the lease from the api

get the checklist items for the lease from the api

combine 1 and 2.

see existing pattern in useLeaseDetail for an example.

devinleighsmith · 2024-05-31T18:51:12Z

source/backend/dal/Repositories/LeaseRepository.cs

@@ -93,6 +94,11 @@ public PimsLease Get(long id)
 .Include(l => l.LeaseCategoryTypeCodeNavigation)
 .Include(l => l.LeaseStatusTypeCodeNavigation)
 .Include(l => l.PimsLeaseTenants)
+ .Include(l => l.PimsLeaseChecklistItems)


normally we try and not include deeply nested (ie. grandchild or lower) entities in our responses, is there a reason for this?

devinleighsmith · 2024-05-31T18:52:14Z

source/backend/dal/Repositories/LeaseRepository.cs

+ }
+
+ /// <summary>
+ /// Add a new cehclist item to the lease.


nit: checklist

devinleighsmith · 2024-05-31T18:53:27Z

source/backend/entities/Partials/LeaseChecklistItemType.cs

+ /// <summary>
+ /// PimsLeaseChklstItemType class, provides an entity for the datamodel to manage a list of lease checklist item types.
+ /// </summary>
+ public partial class PimsLeaseChklstItemType : IBaseEntity, IExpiringTypeEntity<DateOnly, DateOnly?>


partial class does not match file name

devinleighsmith · 2024-05-31T18:53:51Z

source/backend/entities/Partials/LeaseChecklistItemStatusType.cs

+ /// <summary>
+ /// PimsLeaseChklstItemStatusType class, provides an entity for the datamodel to manage a list of lease checklist item status types.
+ /// </summary>
+ public partial class PimsLeaseChklstItemStatusType : ITypeEntity<string>


class does not match file name

devinleighsmith · 2024-05-31T18:54:04Z

source/backend/entities/Partials/LeaseChecklistSectionType.cs

+ /// <summary>
+ /// PimsLeaseChklstSectionType class, provides an entity for the datamodel to manage a list of lease checklist section types.
+ /// </summary>
+ public partial class PimsLeaseChklstSectionType : ITypeEntity<string>, IExpiringTypeEntity<DateOnly, DateOnly?>


class does not match file name

devinleighsmith · 2024-05-31T18:54:42Z

source/backend/tests/unit/dal/Repositories/LeaseRepositoryTest.cs

@@ -530,7 +530,7 @@ public void Update_Lease_Null()

 // Act
 lease.LeaseDescription = "updated";
- Action act = () => repository.Update(null);
+ Action act = () => repository.UpdateChecklistItem(null);


this was probably a mistake.

devinleighsmith · 2024-05-31T18:55:56Z

source/frontend/src/features/leases/detail/LeasePages/checklist/LeaseChecklistContainer.tsx

+ onSuccess,
+}) => {
+ const { lease } = React.useContext(LeaseStateContext);
+ // const handleEdit = () => {


no commented out code without a need please.

devinleighsmith · 2024-05-31T19:01:19Z

source/frontend/src/features/mapSideBar/shared/tabs/checklist/detail/ChecklistView.test.tsx

@@ -31,6 +32,7 @@ describe('ChecklistView component', () => {
 const utils = render(
 <ChecklistView
 apiFile={mockViewProps.apiFile}
+ showEditButton={true}


perhaps mockViewProps.showEditButton?

devinleighsmith · 2024-05-31T19:05:18Z

@eddherrera pre-existing leases do not work - they look like this:

devinleighsmith · 2024-05-31T19:10:45Z

Also, have a look at the double scroll bars.

github-actions · 2024-05-31T22:16:08Z

✅ No secrets were detected in the code.

github-actions · 2024-05-31T22:59:41Z

✅ No secrets were detected in the code.

github-actions · 2024-05-31T23:05:38Z

✅ No secrets were detected in the code.

codecov · 2024-05-31T23:10:16Z

Codecov Report

Attention: Patch coverage is 30.87248% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 76.21%. Comparing base (29129d9) to head (15a4f21).

❗ Current head 15a4f21 differs from pull request most recent head 24bf5d0

Please upload reports for the commit 24bf5d0 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##              dev    #4062       +/-   ##
===========================================
- Coverage   85.32%   76.21%    -9.11%     
===========================================
  Files        1610      492     -1118     
  Lines      121322    18169   -103153     
  Branches     9362     1257     -8105     
===========================================
- Hits       103514    13848    -89666     
+ Misses      17504     4016    -13488     
- Partials      304      305        +1

Flag	Coverage Δ
unittests	`76.21% <30.87%> (-9.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
source/backend/api/Controllers/LookupController.cs	`100.00% <100.00%> (ø)`
...els/Models/Concepts/Lease/LeaseChecklistItemMap.cs	`100.00% <100.00%> (ø)`
...Models/Concepts/Lease/LeaseChecklistItemTypeMap.cs	`100.00% <100.00%> (ø)`
...ackend/apimodels/Models/Concepts/Lease/LeaseMap.cs	`100.00% <100.00%> (ø)`
...ource/backend/dal/Repositories/LookupRepository.cs	`87.17% <0.00%> (-2.30%)`	⬇️
...nd/api/Areas/Leases/Controllers/LeaseController.cs	`68.33% <0.00%> (-22.78%)`	⬇️
source/backend/dal/Repositories/LeaseRepository.cs	`94.23% <7.14%> (-3.48%)`	⬇️
source/backend/api/Services/LeaseService.cs	`35.18% <20.00%> (-3.66%)`	⬇️

... and 1120 files with indirect coverage changes

github-actions · 2024-05-31T23:40:21Z

✅ No secrets were detected in the code.

devinleighsmith · 2024-06-03T16:07:20Z

@eddherrera had another look, pre-existing leases have the same reported issue.

github-actions · 2024-06-03T18:54:35Z

✅ No secrets were detected in the code.

* psp-8108 style changes for improvements page. (#4066) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.22 * make the file pretext on file headers in front of file status bold. (#4067) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.23 * PSP-8552 : FT: Map View- Historical file number search is not working… (#4065) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.24 * modify tooltip render direction to avoid clipping. (#4069) * modify tooltip render direction to avoid clipping. * also correct remarks section. --------- Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.25 * psp-8499 | Updated historical number rendering for leases (#4050) * Updated historical number rendering for leases * Fixed tests * Updated placeholder and duplicate logic for Historical File # * CI: Bump version to v5.3.0-81.26 * Features/psp 7494 (#4068) * Updated the deposts page * Fixed stylings for buttons and margin for collapsable section * updated snaps * PR comment updates. --------- Co-authored-by: FuriousLlama <marobej@gmail.com> Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-81.27 * PSP-8315 : Add Lease and License Checklist (#4062) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.28 * psp-8585 display either retired or disposed status in property header… (#4075) * psp-8585 display either retired or disposed status in property header if relevant Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> * psp-8585 code review corrections --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> * CI: Bump version to v5.3.0-81.29 * psp-8568 fix database scripts such that the draft disposition status is actually disabled. (#4076) * CI: Bump version to v5.3.0-81.30 --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Herrera <eduardo.herrera@quartech.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>

* Psp 8109 - color palette refactor (#3951) * psp-8109 app color updates. * fix * test corrections. * merge correction. * psp-8109 cleanup, PR feedback. * corrections. * formatting. * snapshots. * 5.3 updates from dev (#3983) * Bump DEV version - IS79 (#3974) * CI: Bump version to v5.2.0-79.1 * psp-7999 close button styling (#3973) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.2.0-79.2 * IS-79.00 Database Schema (#3969) * IS-79.00 Database Schema PSP_PIMS | Development Sprint: S79.00 | Design Sprint: 78 | Date: 2024-Apr-23 - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_PROPERTY - Added seed scripts: - 007_PSP_PIMS_ACQUISITION_FILE_HIST_Add.sql - 151_DML_PIMS_FILE_NUMBER_TYPE.sql - Altered seed scripts: - 116_DML_PIMS_TAKE_TYPE.sql - Altered test scripts: - 031_PIMS_ACQUISITION_FILE.sql - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - 043_PIMS_ACQUISITION_FILE.sql - 058_PIMS_TAKE.sql - Added test scripts: - 075_PIMS_FILE_NUMBER.sql - Requires additional metadata to meet standards * Updated Lease Purpose Codes Late addition to the release. --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v5.2.0-79.3 * Scaffold/s79 (#3975) * Generated scaffold * Compilation fixes * CI: Bump version to v5.2.0-79.4 * PSP-8182: Automation update based on last changes on TST Environment (#3976) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v5.2.0-79.5 * snapshot updates. (#3977) * CI: Bump version to v5.2.0-79.6 * vitest corrections (#3978) * vitest fixes. * re-install moment-timezone. * remove only modifier * snapshot update. * skip failing test. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * acquisition file owners. * CI: Bump version to v5.2.0-79.7 * PSP-8022 : Disposition file states - Hold (#3979) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.2.0-79.8 * psp-7909 take ui refactor. (#3980) * psp-7909 take ui refactor. * psp-8145 * correct invalid type. * code review corrections. * merge corrections. * CI: Bump version to v5.2.0-79.9 * unit test stability corrections (#3982) * vitest fixes. * re-install moment-timezone. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * update msw, make some corrections to aid with test instability. * increase maxworkers now that test stability increased. * package updates. * CI: Bump version to v5.2.0-79.10 * snapshots --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Herrera <eduardo.herrera@quartech.com> * psp-5489 | Lease header historical numbers (#3990) * added backend and frontend components * Regenerated snaps * psp-7861 Historical file numbers on Acquisition file and Research file (#4000) * added backend and frontend components * Regenerated snaps * Addes historical numbers to the acq and research headers * Updated snaps * Manual merge * 5.3 test fixes (#4007) * CI: Bump version to v5.2.0-79.27 * Bump DEV version to 5.3 (#4008) * CI: Bump version to v5.3.0-80.1 * PSP-8444: Update on Automated Takes (#4011) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment * Changes on automation based on IS79 changes * Takes update * Takes update --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v5.3.0-80.2 * IS-80.00 Database Schema (#3999) * IS-80.00 Database Schema PSP_PIMS | Development Sprint: S80.00 | Design Sprint: 79 | Date: 2024-May-07 - Added tables: - PIMS_HISTORICAL_FILE_NUMBER - PIMS_HISTORICAL_FILE_NUMBER_HIST - PIMS_HISTORICAL_FILE_NUMBER_TYPE - Altered tables: - PIMS_INSURANCE - PIMS_LEASE - PIMS_LEASE_HIST - PIMS_PROPERTY - Dropped tables: - PIMS_FILE_NUMBER - PIMS_FILE_NUMBER_HIST - PIMS_FILE_NUMBER_TYPE - Added views: - PIMS_HISTORICAL_FILE_NUMBER_VW - PIMS_PROPERTY_VW - Altered views: - PIMS_PROPERTY_BOUNDARY_VW - PIMS_PROPERTY_LOCATION_VW - Added seed scripts: - 151_DML_PIMS_HISTORICAL_FILE_NUMBER_TYPE.sql - Altered seed scripts: - 072_DML_PIMS_INSURANCE_TYPE.sql - 073_DML_PIMS_LEASE_STATUS_TYPE.sql - 083_DML_PIMS_RESEARCH_FILE_STATUS_TYPE.sql - 138_DML_PIMS_DISPOSITION_FILE_STATUS_TYPE.sql - Added test scripts: - 075_HISTORICAL_PIMS_FILE_NUMBER.sql - Altered test scripts: - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - 031_PIMS_ACQUISITION_FILE.sql - 043_PIMS_ACQUISITION_FILE.sql - 060_PIMS_DISPOSITION_FILE.sql - Requires additional metadata to meet standards * Deleted 151_DML_PIMS_FILE_NUMBER_TYPE.sql * Deleted Schema Compare from LATEST Alter Down * Deleted Non-Historical File Number Test Data Script --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v5.3.0-80.3 * Scaffold for s80 and compilation fixes (#4017) * Generated scaffold * Fixed compilation issues * CI: Bump version to v5.3.0-80.4 * correct modal close icon, text. (#4015) * correct modal close icon, text. * snapshot updates. --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-80.5 * Added historical file numbers to the disposition header (#4012) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-80.6 * PSP-8256 : Remove PS and LIS number from lease/area (#4013) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-80.7 * PSP-8225 : Adjust "historical file number" on the lease/license search to search across all Historical Numbers (#4010) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-80.8 * Updated lease header files and initial work on other file headers * Psp 8313 - display lease file association updates. (#4014) * psp-8313 Display lease file associations. * Update based on question in story - certain tenant types need not be displayed. * CI: Bump version to v5.3.0-80.9 * PSP-5492 Update Historical # and Type on Property Details (Property Attributes) (#4016) * Update frontend service calls to API * Add new type code dropdown * Update historical numbers - frontend * Save the list of historical file numbers * Clear associated fields when historical file number type is changed * Controller, service and repository changes for updating historical numbers * Test updates * Update form validation rules * Test corrections * Fix merge conflicts * Lint fixes * CR feedback * Fix model mappings * Fix lookup table key * CI: Bump version to v5.3.0-80.10 * Initial changes to fruther improve headers * Fixed property zoom on property header * Updated property header * PSP-6900 * snapshots update * CI: Bump version to v5.3.0-80.11 * PSP-7493 lease insurance UI cleanup (#4024) * Lease insurance UI/IX cleanup * Test corrections * Update lease insurance view based on BA feedback * Test corrections * Fix merge conflicts * CR feedback * CI: Bump version to v5.3.0-80.12 * psp-5511 display mayan document previews. (#4009) * psp-5511 display mayan document previews. * code review updates. --------- Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-80.13 * Updated lease header files and initial work on other file headers (#4018) * CI: Bump version to v5.3.0-80.14 * Manual merge and renegerated snaps * psp-7417 add health checks for Major pims services. (#4025) * psp-7417 add health checks for Major pims services. * remove mocked auth code. * CI: Bump version to v5.3.0-80.15 * PSP-8314 : Record reason for rejecting or terminating a lease (#4023) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-80.16 * proposal - styled modal that warns the user is leaving a form. (#3966) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-80.17 * CI: Bump version to v5.3.0-80.18 * CI: Bump version to v5.3.0-80.19 * psp-8228 | Updated header status display (#4028) * Added generic status component for headers * Updated tests * CI: Bump version to v5.3.0-80.20 * psp-8415 correct permissions on insurance controller. (#4027) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-80.21 * psp-8185 remove closebutton generic modal prop - show custom pims clo… (#4026) * psp-8185 remove closebutton generic modal prop - show custom pims close button by default. * fix notes spacing. --------- Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-80.22 * CI: Bump version to v5.3.0-80.23 * PSP-4089 FT-REG: Property Info - When getting a Land Parcel Type that is not defined by PIMS, on edit mode, should display the default option as "Unknown" (#4032) * Update api models * Lint fixes * Set property type to UNKNOWN for disabled code values * CI: Bump version to v5.3.0-80.24 * Psp-8424 download animation correction - also unrelated eslint fix. (#4030) * correct download loading animation. * style corrections psp-8424 * snapshot updates. --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-80.25 * Psp 8486 ensure organizations are displayed in file association tenants for leases. (#4031) * psp-8486 ensure orgs display in file associations. * correct display of error icon, ensure that re-loading an errored page removes the error. * snapshot updates. * CI: Bump version to v5.3.0-80.26 * Fixed lease warning not showing (#4038) * CI: Bump version to v5.3.0-80.27 * CI: Bump version to v5.3.0-80.28 * Bump DEV version - IS81 (#4041) * CI: Bump version to v5.3.0-81.1 * PSP-8114 : Expose Mayan errors to frontend (temporarily) (#3972) * CI: Bump version to v5.3.0-81.2 * UI/improvements (#4036) * Removed repeated styles and improved padding * Updated input to match styled mocups and icons * Updated Styling for multiselect and contact input * linting * Regenerated snaps * Updated remove button alignment on project subform * CI: Bump version to v5.3.0-81.3 * Automation test cases update based on IS80 * IS-81.00 Database Schema (#4034) * IS-81.00 Database Schema PSP_PIMS | Development Sprint: S81.00 | Design Sprint: 80 | Date: 2024-May-22 - Added tables: - PIMS_LEASE_CHECKLIST_ITEM - PIMS_LEASE_CHECKLIST_ITEM_HIST - PIMS_LEASE_CHKLST_ITEM_STATUS_TYPE - PIMS_LEASE_CHKLST_ITEM_TYPE - Altered tables: - PIMS_LEASE - Added seed scripts: - 152_DML_PIMS_LEASE_CHKLST_SECTION_TYPE.sql - 153_DML_PIMS_LEASE_CHKLST_ITEM_TYPE.sql - 154_DML_PIMS_LEASE_CHKLST_ITEM_STATUS_TYPE.sql - Altered seed scripts: - 072_DML_PIMS_INSURANCE_TYPE.sql - 049_DML_PIMS_DATA_SOURCE_TYPE.sql - Added test scripts: - 076_PIMS_PIMS_LEASE_CHECKLIST_ITEM.sql - Altered test scripts: - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - Requires additional metadata to meet standards * Updated IS-81 Database Schema * Updated build. Removed Historical file number # from LIS and PS --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v5.3.0-81.4 * Automation test cases update based on IS80 * PSP-8501 * Generated scaffold for s81 (#4047) * CI: Bump version to v5.3.0-81.5 * PSP-8227 : Add search for "historical file number" on the property se… (#4033) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.6 * updated lease tenant page (#4044) * CI: Bump version to v5.3.0-81.7 * CI: Bump version to v5.3.0-81.8 * CI: Bump version to v5.3.0-81.9 * Areas fields displaying at most 4 decimals * PSP-8543 : update appsettings files so that a default is provided for Mayan__ExposeErrors (#4053) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.10 * snapshots update * updating unit test cases * psp-8531 correct the disposition header icon (#4056) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.11 * Test case update * CI: Bump version to v5.3.0-81.12 * pims document preview - stability. (#4039) * CI: Bump version to v5.3.0-81.13 * psp-8549 correct property header retired status styling. (#4060) * CI: Bump version to v5.3.0-81.14 * psp-8470 tooltip for lease statuses. (#4058) * CI: Bump version to v5.3.0-81.15 * psp-8534 add 'file:' in front of status on file headers. (#4057) Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-81.16 * Psp 8099 - allow special instruction whitespace to display. (#4043) * CI: Bump version to v5.3.0-81.17 * psp-8545 property ownership filter fixes. (#4054) * prevent automatic refresh of secondary ownership filter. * test fixes --------- Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-81.18 * psp-5576 update select all button behaviour, ensure paged selections are not lost. (#4059) Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-81.19 * psp-8477 - use fully attributed parcel map. (#4046) * psp-8477 - use fully attributed parcel map. * display a warning if the siteminder session expires. * snapshot updates. * snapshot updates. * code review corrections. * CI: Bump version to v5.3.0-81.20 * PSP-8555: Update .NET sonarscanner in GitHub actions to support .NET 8 (#4064) * Update sonar-scanner to support .NET 8 * Linting * CI: Bump version to v5.3.0-81.21 * psp-8108 style changes for improvements page. (#4066) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.22 * make the file pretext on file headers in front of file status bold. (#4067) Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.23 * PSP-8552 : FT: Map View- Historical file number search is not working… (#4065) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.24 * modify tooltip render direction to avoid clipping. (#4069) * modify tooltip render direction to avoid clipping. * also correct remarks section. --------- Co-authored-by: Smith <devin.smith@quartech.com> * CI: Bump version to v5.3.0-81.25 * psp-8499 | Updated historical number rendering for leases (#4050) * Updated historical number rendering for leases * Fixed tests * Updated placeholder and duplicate logic for Historical File # * CI: Bump version to v5.3.0-81.26 * Features/psp 7494 (#4068) * Updated the deposts page * Fixed stylings for buttons and margin for collapsable section * updated snaps * PR comment updates. --------- Co-authored-by: FuriousLlama <marobej@gmail.com> Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v5.3.0-81.27 * PSP-8315 : Add Lease and License Checklist (#4062) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.28 * psp-8585 display either retired or disposed status in property header… (#4075) * psp-8585 display either retired or disposed status in property header if relevant Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> * psp-8585 code review corrections --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> * CI: Bump version to v5.3.0-81.29 * psp-8568 fix database scripts such that the draft disposition status is actually disabled. (#4076) * CI: Bump version to v5.3.0-81.30 * PSP-8587 table pagination visual bug (#4078) * PSP-8587 Fix table pagination visual bug * Update snapshots * CI: Bump version to v5.3.0-81.31 * PSP-8586 : FT-REG: Subdivision/ Consolidation - Menu icon enlarges when user clicks on expand the left menu section (#4077) Co-authored-by: Herrera <eduardo.herrera@quartech.com> * CI: Bump version to v5.3.0-81.32 * PSP-8536: Property Information Details - Historical File, Headers. (#4071) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment * Changes on automation based on IS79 changes * Takes update * Takes update * Changes in Property Details - Historical File and Headers --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v5.3.0-81.33 * psp-8586 auto-format corrections. (#4082) * CI: Bump version to v5.3.0-81.34 * CI: Bump version to v5.3.0-81.35 --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Herrera <eduardo.herrera@quartech.com> Co-authored-by: Sue Tairaku <sue.tairaku@gmail.com> Co-authored-by: Smith <devin.smith@quartech.com> Co-authored-by: devinleighsmith <devinleighsmith@gmail.com>

PSP-8315 : Add Lease and License Checklist

cb8973f

eddherrera requested review from asanchezr and devinleighsmith May 30, 2024 21:01

eddherrera self-assigned this May 31, 2024

eddherrera added enhancement New feature or request 5.3 labels May 31, 2024

devinleighsmith reviewed May 31, 2024

View reviewed changes

Herrera added 2 commits May 31, 2024 13:58

Merge branch 'dev' into psp-8315

48f1324

- updates

6e9f7b7

- fixes

f276f01

Merge branch 'dev' into psp-8315

15a4f21

eddherrera marked this pull request as ready for review May 31, 2024 23:03

- test fixes

5ba5fb5

eddherrera requested a review from devinleighsmith May 31, 2024 23:38

- add items to checklist no matter the lease date or the lease status.

24bf5d0

devinleighsmith approved these changes Jun 3, 2024

View reviewed changes

eddherrera merged commit 078f185 into bcgov:dev Jun 3, 2024
7 checks passed

eddherrera deleted the psp-8315 branch June 6, 2024 19:40

github-actions bot mentioned this pull request Aug 19, 2024

Yearly issue metrics report for opened issues and prs devinleighsmith/PSP#196

Open

devinleighsmith mentioned this pull request Aug 19, 2024

Pull requests report(19/08/2024 21:02) #4274

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PSP-8315 : Add Lease and License Checklist #4062

PSP-8315 : Add Lease and License Checklist #4062

eddherrera commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024 •

edited

Loading

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith May 31, 2024

eddherrera May 31, 2024

devinleighsmith commented May 31, 2024

devinleighsmith commented May 31, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

codecov bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024

devinleighsmith commented Jun 3, 2024

github-actions bot commented Jun 3, 2024

PSP-8315 : Add Lease and License Checklist #4062

PSP-8315 : Add Lease and License Checklist #4062

Conversation

eddherrera commented May 30, 2024 • edited Loading

github-actions bot commented May 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinleighsmith May 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinleighsmith commented May 31, 2024

devinleighsmith commented May 31, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

github-actions bot commented May 31, 2024

codecov bot commented May 31, 2024 • edited Loading

Codecov Report

github-actions bot commented May 31, 2024

devinleighsmith commented Jun 3, 2024

github-actions bot commented Jun 3, 2024

eddherrera commented May 30, 2024 •

edited

Loading

devinleighsmith May 31, 2024 •

edited

Loading

codecov bot commented May 31, 2024 •

edited

Loading