-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSP-7158 Show markers positioned corresponding to that file #4147
PSP-7158 Show markers positioned corresponding to that file #4147
Conversation
✅ No secrets were detected in the code. |
acdfae2
to
cd85ac6
Compare
✅ No secrets were detected in the code. |
cd85ac6
to
6555c79
Compare
✅ No secrets were detected in the code. |
&& filePropertyToUpdate is PimsPropertyAcquisitionFile acquisitionPropertyToUpdate) | ||
{ | ||
// convert spatial location from lat/long (4326) to BC Albers (3005) for database storage | ||
var geom = incomingAcquisitionProperty.Location; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the above casting also check for null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - a note that this casting will go away this sprint with the story to use location on other file types
if (fileProperty is PimsPropertyAcquisitionFile acquisitionFileProperty) | ||
{ | ||
// convert spatial location from lat/long (4326) to BC Albers (3005) for database storage | ||
var geom = acquisitionFileProperty.Location; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this casting check for null?
@@ -102,6 +93,20 @@ export class DispositionFormModel implements WithDispositionTeam { | |||
}; | |||
} | |||
|
|||
private toPropertyApi(x: PropertyForm): ApiGen_Concepts_DispositionFileProperty { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth creating a single function that converts to ApiGen_Concepts_FileProperty instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could create that for the 2 files that don't have extra info in there (Disposition and Acquisition). Research and Lease I believe have extra fields but we could call the shared function and then append the extra stuff. Will look into it
6555c79
to
4de8c22
Compare
✅ No secrets were detected in the code. |
4de8c22
to
a372805
Compare
✅ No secrets were detected in the code. |
a372805
to
a44409e
Compare
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
Merging this PR as-is to get it to FT. I will address PR comments in my next related PR |
video.mp4