Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psp 8855 correct lease-specific property attribution when adding from the map. #4202

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Psp 8855 correct lease-specific property attribution when adding from the map. #4202

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a87cb5c
psp-8855 ensure that a property selected from the map shows up on the…
devinleighsmith Jul 15, 2024
47e3a8b
psp-8855 nsure that a property selected from the map shows up on the …
devinleighsmith Jul 15, 2024
6927f7e
snapshot updates.
devinleighsmith Jul 15, 2024
5307933
test correction.
devinleighsmith Jul 15, 2024
72cc1da
ensure that properties are added to lease before adding to form.
devinleighsmith Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/frontend/src/features/leases/add/AddLeaseForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,16 @@ const AddLeaseForm: React.FunctionComponent<React.PropsWithChildren<IAddLeaseFor
propertyInfo,
}) => {
const defaultFormLease = getDefaultFormLease();
const apiFormLease = LeaseFormModel.toApi(defaultFormLease);

const { getByType } = useLookupCodeHelpers();
const consultationTypes = getByType(API.CONSULTATION_TYPES);
apiFormLease.consultations = getConsultations(apiFormLease, consultationTypes);
if (propertyInfo) {
defaultFormLease.properties = [];
defaultFormLease.properties.push(FormLeaseProperty.fromMapProperty(propertyInfo));
defaultFormLease.regionId = propertyInfo.region ? propertyInfo.region.toString() : '';
}
const apiFormLease = LeaseFormModel.toApi(defaultFormLease);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing the conversion to an apiFormLease after the properties are added to the defaultFormLease now.

apiFormLease.consultations = getConsultations(apiFormLease, consultationTypes);

const handleSubmit = async (
values: LeaseFormModel,
Expand Down
Loading