Highway layer map popup enhancement | PSP-8332 #4230
Conversation
…pagination for each source
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
| setLayerPopup({ | ||
| latlng: mapMachine.mapLocationFeatureDataset.location, | ||
| layers: layersData, | ||
| }); |
There was a problem hiding this comment.
I see duplicated calls to "setLayerPopup()" here and later on line 112...
Given that we are already calling it in line 112 - could this call be removed?
| }, | ||
| MOTI_PLAN: { label: 'MOTI plan', display: (data: { [key: string]: any }) => data.MOTI_PLAN }, | ||
| VETTING_STATUS: { | ||
| label: 'Venting Status', |
There was a problem hiding this comment.
typo: venting -> vetting
| }, | ||
| SHAPE_TYPE: { label: 'Shape type', display: (data: { [key: string]: any }) => data.SHAPE_TYPE }, | ||
| PENDING_CLASSIFICATION: { | ||
| label: 'Pending clasification', |
There was a problem hiding this comment.
typo: clasification -> classification
| * API wrapper to centralize all AJAX requests to WFS endpoints for the pims property location. | ||
| * @returns Object containing functions to make requests to the WFS layer. | ||
| * Note: according to the view ISS_ProvincialPublicHighway |
There was a problem hiding this comment.
"...WFS endpoints for the pims property location" -> "... for the highway layer locations"
|
|
||
| import { ISS_ProvincialPublicHighway } from '../models/layers/pimsHighwayLayer'; | ||
|
|
||
| const getFakeISSResult: () => FeatureCollection<Geometry, ISS_ProvincialPublicHighway> = () => ({ |
There was a problem hiding this comment.
nit: we have been calling these functions "getMock..." instead of "getFake..." - would appreciate keeping it consistent
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
FuriousLlama
changed the title
FuriousLlama
changed the title
Added Highway layer provider and types.
Updated map flyout to have a pagination for each source