PSP-7885 Improve interaction - with advanced search by retaining results #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asanchezr
force-pushed
the
psp-7885-adv-filter
branch
from
ce6a7a0
to
a861c56
Compare
| exit: [send({ type: 'REFRESH_PROPERTIES' })], | ||
| mapFilterOpened: { | ||
| entry: [ | ||
| send({ type: 'REFRESH_PROPERTIES', searchCriteria: defaultPropertyFilter }), |
There was a problem hiding this comment.
Hmm, not sure if this makes sense anymore. Right now, every time I open the sidebar the property refresh event fires, even if I don't change anything within the advanced filter. Given that I haven't changed the filter, I'm not sure why a refresh would be necessary.
devinleighsmith
requested changes
Sep 23, 2024
asanchezr
force-pushed
the
psp-7885-adv-filter
branch
from
202a10d
to
13accfa
Compare
Updated. Please re-review |
devinleighsmith
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video.mp4