Feat/clearer diffs #1910
Merged
Feat/clearer diffs #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikevespi
force-pushed
the
feat/clearer-diffs
branch
from
473f4ad to
a58d853
Compare
mikevespi
force-pushed
the
feat/clearer-diffs
branch
from
a5d14ec to
32bd1d3
Compare
…will change (no states in between)
…statuses in project form summary
…SummaryReportFormSummary
mikevespi
force-pushed
the
feat/clearer-diffs
branch
from
32bd1d3 to
62785eb
Compare
pbastia
approved these changes
May 24, 2024
| @@ -65,6 +67,12 @@ const AttachmentTableRow: React.FC<Props> = ({ | |||
| return ( | |||
| <> | |||
| <tr> | |||
| {operation && ( | |||
| <td> | |||
| {operation.charAt(0).toUpperCase() + | |||
There was a problem hiding this comment.
Nice! This will help clarify for our users
Comment on lines
+58
to
+59
| formDataTableName: "reporting_requirement" | ||
| reportType: "TEIMP" |
There was a problem hiding this comment.
This was a bug the whole time, right?
There was a problem hiding this comment.
It was, so these would always have been showing up as new and the previous data in tests was always empty
| }, | ||
| latestCommittedReportMap[ | ||
| milestoneReport.newFormData.reportingRequirementIndex | ||
| ] |
There was a problem hiding this comment.
Sweet, I think this was missing in the first place right?
Comment on lines
74
to
75
| proponentsSharePercentage: 10, // will trigger three diffs | ||
| totalProjectValue: 12, // will trigger three diffs |
There was a problem hiding this comment.
Comment needs adjusting, we don't display three diffs anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way the custom diff fields represent the changes. The fields will now show the latest committed state (if any), and what will be changed/added/removed in the committing project revision. The intent is that it will be easier for users to discern what they will be changing about a project when applying a revision by avoiding showing them any intermittent states the project may have been in between the revision being created, and now.