Fix: Enrolment Overview Error Miss Reporting (#2141)

Enrolment errors should only represent states that mean the overview is false, not just helper methods for deciding error messaging. Not having a cert is not an error but just used in the review page for message logic.

prime-angular-frontend/src/app/modules/enrolment/pages/overview/overview.component.ts

@@ -215,7 +215,6 @@ export class OverviewComponent extends BaseEnrolmentPage implements OnInit {
  */
  private getEnrolmentErrors(enrolment: Enrolment): ValidationErrors {
  return {
- certificate: !enrolment.certifications?.length,
  certificateOrOboSite: !enrolment.certifications?.length && !enrolment.oboSites?.length,
  deviceProvider: enrolment.careSettings.some((careSetting) => careSetting.careSettingCode === CareSettingEnum.DEVICE_PROVIDER)
  && !enrolment.deviceProviderIdentifier,

prime-angular-frontend/src/app/shared/components/enrollee/enrollee-review/enrollee-review.component.html

@@ -236,7 +236,7 @@
 
  <app-enrollee-property *ngIf="!hasCertification"
  title="College Certification"
- [hasError]="enrolmentErrors?.certificateOrOboSite && enrolmentErrors?.certificate"
+ [hasError]="enrolmentErrors?.certificateOrOboSite"
  errorMessage="Must have a college certificate or job site information"
  [makeBold]="true">
  None
@@ -316,9 +316,9 @@
  title="Job Sites"
  [hasError]="enrolmentErrors?.certificateOrOboSite || enrolmentErrors?.deviceProviderOrOboSite"
  errorMessage="Must have a {{
-  enrolmentErrors?.certificate && enrolmentErrors?.deviceProvider
+ !hasCertification && enrolmentErrors?.deviceProvider
  ? 'college certificate and a device provider ID'
- : enrolmentErrors?.certificate
+ : !hasCertification
  ? 'college certificate'
  : 'device provider ID'
  }} or job site information"