Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRIME-2706 Mismatch Missing Business License flag in Admin #2506

Merged

Conversation

bergomi02
Copy link
Collaborator

No description provided.

@bergomi02 bergomi02 self-assigned this May 9, 2024
@bergomi02 bergomi02 added Frontend Updates to the frontend of the application Ready For Review PR is ready for code review labels May 9, 2024
@neophyte57
Copy link
Collaborator

@bergomi02 I'm trying to understand what this PR fixes ... previously there was a bug that enabled CP Site Registrations to be created with No Business Licence but a Business Licence Expiry Date that was set? Is there an instance of such data in the dev environment?

@bergomi02
Copy link
Collaborator Author

@bergomi02 I'm trying to understand what this PR fixes ... previously there was a bug that enabled CP Site Registrations to be created with No Business Licence but a Business Licence Expiry Date that was set? Is there an instance of such data in the dev environment?

This should fix any discrepancy between the two pages. Here is the example in DEV:
image
For "Site C", the missing business license is marked "Yes".
image
in the overview page, it marked as "No".

Copy link
Collaborator

@neophyte57 neophyte57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

@bergomi02 bergomi02 merged commit eab5e82 into develop Jul 11, 2024
13 checks passed
@bergomi02 bergomi02 deleted the fix/prime-2706_mismatch_missing_business_licence_flag branch July 11, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Updates to the frontend of the application Ready For Review PR is ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants