Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building issue - codeclimate check error #2584

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix building issue - codeclimate check error #2584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
defaults:
run:
working-directory: ./prime-angular-frontend

if: github.ref != 'develop' || (github.ref == 'develop' && github.event.pull_request.merged == true)

runs-on: ubuntu-latest
Expand Down Expand Up @@ -59,15 +59,15 @@ jobs:
- name: Collect Frontend Report
run: |
cc-test-reporter format-coverage -t lcov -o coverage/frontend.json coverage/lcov.info

- name: Create frontend coverage file artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: frontend
path: ./prime-angular-frontend/coverage/frontend.json
retention-days: 1


collect-backend-coverage:
defaults:
run:
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
run: |
cd ../
dotnet tool install -g dotnet-reportgenerator-globaltool --version 5.3.6

- uses: amancevice/setup-code-climate@v0
with:
cc_test_reporter_id: ${{ secrets.CC_TEST_REPORTER_ID }}
Expand All @@ -122,12 +122,12 @@ jobs:
cd ../prime-dotnet-webapi
cc-test-reporter format-coverage -t lcov -o ../prime-dotnet-webapi-tests/coverage/backend.json ../prime-dotnet-webapi-tests/coverage/lcov.info -p /home/runner/work/moh-prime/moh-prime/prime-dotnet-webapi
- name: Create backend coverage file artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: backend
path: ./prime-dotnet-webapi-tests/coverage/backend.json
retention-days: 1


codeclimate-sum-coverage:
needs: [ collect-frontend-coverage, collect-backend-coverage ]
Expand All @@ -146,25 +146,25 @@ jobs:
cc_test_reporter_version: latest # optional

- name: Download frontend artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: frontend
# path: frontend/

- name: Download backend artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: backend
# path: backend/

- name: Sum files
run: |
run: |
cc-test-reporter sum-coverage -p 2 frontend.json backend.json
cc-test-reporter upload-coverage -i ./coverage/codeclimate.json

- name: Create summed report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: summed
path: ./coverage/codeclimate.json
retention-days: 1
retention-days: 1
Loading